Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds optional username/password authentication for Redis #4883

Draft
wants to merge 2 commits into
base: stable
Choose a base branch
from

Conversation

wvandeun
Copy link
Contributor

@wvandeun wvandeun commented Nov 7, 2024

No description provided.

@wvandeun wvandeun self-assigned this Nov 7, 2024
@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Nov 7, 2024
@ogenstad
Copy link
Contributor

ogenstad commented Nov 7, 2024

Depending on how this is used it might need some more work as we're also using Redis for the distributed lock as well as for some Prefect tasks and unfortunately the Redis connection isn't synced or managed in the same way between them.

Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #4883 will not alter performance

Comparing wvd-20241107-fix-redis-username-password-auth (b729401) with stable (68d105f)

Summary

✅ 10 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants