Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittest to pytest Test message #2046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

unittest to pytest Test message #2046

wants to merge 1 commit into from

Conversation

Ok3ks
Copy link

@Ok3ks Ok3ks commented Oct 23, 2024

Description

Converted test_message.py from Unittest to pytest

Fixes

Migrate tests from unittest to pytest #1502

Status

READY

Type of change

How Has This Been Tested?

  • Test A
    With Pytest, modifying the get_connector fixture to have initialised Opsdroid() instead of None

Checklist:

  • [Y ] I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • [Y] I have added tests that prove my fix is effective or that my feature works
  • [Y] New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the tests label Oct 23, 2024
@Ok3ks Ok3ks mentioned this pull request Oct 23, 2024
Open
jacobtomlinson
jacobtomlinson requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Can you also remove the original unittest tests that you've converted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson requested changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ok3ks @jacobtomlinson