-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18next plugin parser does not support plurals #1069
Comments
Inlang core eventually needs plugralization support. If you can hack something in the plugin, great. If not, we gotta prioritize adding plurals to the AST in core. |
@NilsJacobsen I assigned you because we need to default assign issues to ensure they get handled |
@NilsJacobsen @NiklasBuchfink @samuelstroschein Great to see that the Message format we adopted now supports plurals ootb. We can now go ahead and improve the plugin parser. |
I close this as the infrastructure now allows the implementation of plurals |
@NiklasBuchfink but the i18next plugin doesn't parse plurals :) |
@samuelstroschein We should introduce this feature for all apps and plugins together. Until then, nothing will happen in this issue. |
This problem was comming up in this PR: mifi/lossless-cut#1653
Problem
i18next has pluarls support -> https://www.i18next.com/translation-function/plurals
t('key', {count: 1})
The current implementation of the parser is just passing the key, causing the ide extension to handle the wrong key.
Proposal
Improve the plugin parser to recognize the count option as the ns option and suffix the key.
@inlang/plugins @inlang/ide-extension
The text was updated successfully, but these errors were encountered: