Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support for variants in editor #1217

Closed
2 tasks
samuelstroschein opened this issue Aug 7, 2023 · 7 comments
Closed
2 tasks

[feature] support for variants in editor #1217

samuelstroschein opened this issue Aug 7, 2023 · 7 comments
Assignees
Labels
scope: inlang/fink-editor Related to source-code/website/editor. type: feature New feature or request

Comments

@samuelstroschein
Copy link
Member

samuelstroschein commented Aug 7, 2023

Description

The core refactoring enabled variants. The editor needs to support variants.

Tasks

  • ...
  • ...
@samuelstroschein samuelstroschein converted this from a draft issue Aug 7, 2023
@maige-app maige-app bot added type: feature New feature or request scope: inlang/fink-editor Related to source-code/website/editor. labels Aug 7, 2023
@samuelstroschein
Copy link
Member Author

@inlang/editor the editor needs variant support. for the MVP version, it probably easiest if we have a matric view like https://github.com/unicode-org/message-format-wg/blob/main/spec/syntax.md#complex-messages.

i give you the decision when variants should be supported in the editor. adjust the start and target date in the roadmap.

@NiklasBuchfink
Copy link
Member

I would prioritize as follows:

  1. Make the editor work again for current users (after the refactoring)
  2. Improve the change management (no data loss anymore)
  3. Introduce variants

If we could do 1 & 2 next week, we could start with this on August 21 (best case).

@NilsJacobsen
Copy link
Member

Why does the editor need to support it now? I thought we can do that step by step along growth topics after the refactoring? We only have one variant with no selectors for now.

Does something speak against it?

@samuelstroschein
Copy link
Member Author

samuelstroschein commented Aug 7, 2023

Yoo sorry, this roadmap item is after the refactoring is complete. This is unrelated to the core refactoring.

It is clear however that after the core refactoring, variants need to be fully supported by apps, including the editor,. Otherwise, nobody will/can/wants to use variants. Hence, introducing variants in the editor (ecosystem) should be a prio [after the core refactoring]

@NiklasBuchfink
Copy link
Member

@samuelstroschein I close this as not planned for the same reason as #1069 (comment).

@NiklasBuchfink NiklasBuchfink closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2023
@github-project-automation github-project-automation bot moved this to Done in Roadmap Sep 11, 2023
@felixhaeberle
Copy link
Contributor

@inlang/editor we talked about this last week. is now the time to reopen this, or focus not on variant support but growth?

@NilsJacobsen
Copy link
Member

Let's reopen this if we hit the 30% goals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: inlang/fink-editor Related to source-code/website/editor. type: feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants