Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ConsoleErrorPage handler does not count towards backend… #7655

Merged
merged 1 commit into from
Sep 21, 2019

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Sep 21, 2019

Explanation

Per @lilithxxx's comment here, this PR fixes the codebase coverage to be 100% again.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.

@oppiabot
Copy link

oppiabot bot commented Sep 21, 2019

Assigning @kevinlee12 for the first-pass review of this pull request. Thanks!

Copy link
Contributor

@lilithxxx lilithxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 21, 2019

Codecov Report

Merging #7655 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #7655      +/-   ##
===========================================
+ Coverage    83.67%   83.67%   +<.01%     
===========================================
  Files         1106     1106              
  Lines        64402    64401       -1     
  Branches      3654     3654              
===========================================
  Hits         53882    53882              
+ Misses        9336     9335       -1     
  Partials      1184     1184
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 73.28% <ø> (ø) ⬆️
Impacted Files Coverage Δ
core/controllers/pages.py 100% <ø> (+3.85%) ⬆️

Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vojtechjelinek vojtechjelinek changed the title Ensure ConsoleErrorPage handler does not count towards backend test coverage. Ensure ConsoleErrorPage handler does not count towards backend… Sep 21, 2019
@vojtechjelinek vojtechjelinek merged commit b608ba9 into develop Sep 21, 2019
@vojtechjelinek vojtechjelinek deleted the fix-backend-test-coverage branch September 21, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants