Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5455: Resolve crash in AudioViewModel by initializing state variables #5561

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix #5455: Resolve crash in AudioViewModel by initializing state variables #5561

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dc284f
Fix crash in AudioViewModel by initializing state variables
TanishMoral11 Oct 28, 2024
30ca796
Fix crash in AudioViewModel on rotation by ensuring state initialization
TanishMoral11 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/src/main/java/org/oppia/android/app/player/audio/AudioViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,11 @@ class AudioViewModel @Inject constructor(
processPlayStatusLiveData()
}

fun setStateAndExplorationId(newState: State, id: String) {
state = newState
explorationId = id
fun setStateAndExplorationId(newState: State?, id: String?) {
if (newState != null && id != null) {
state = newState
explorationId = id
}
TanishMoral11 marked this conversation as resolved.
Show resolved Hide resolved
}

fun loadMainContentAudio(allowAutoPlay: Boolean, reloadingContent: Boolean) {
Expand All @@ -88,6 +90,8 @@ class AudioViewModel @Inject constructor(
* @param allowAutoPlay If false, audio is guaranteed not to be autoPlayed.
*/
private fun loadAudio(contentId: String?, allowAutoPlay: Boolean, reloadingMainContent: Boolean) {
// Check if 'state' is initialized before proceeding.
TanishMoral11 marked this conversation as resolved.
Show resolved Hide resolved
if (!::state.isInitialized) return
val targetContentId = contentId ?: state.content.contentId
val voiceoverMapping =
state.recordedVoiceoversMap[targetContentId] ?: VoiceoverMapping.getDefaultInstance()
Expand Down
Loading