-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5381 Talkback reads 14 underscore in a question in What is a ratio chapter #5553
base: develop
Are you sure you want to change the base?
Commits on Jul 23, 2024
-
Merge pull request #1 from oppia/develop
Develop (fork) Branch Update
Configuration menu - View commit details
-
Copy full SHA for d819e70 - Browse repository at this point
Copy the full SHA d819e70View commit details
Commits on Jul 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c6f54ea - Browse repository at this point
Copy the full SHA c6f54eaView commit details
Commits on Aug 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d44015b - Browse repository at this point
Copy the full SHA d44015bView commit details
Commits on Aug 26, 2024
-
Merge pull request #2 from oppia/develop
Develop (fork) Branch Update #2
Configuration menu - View commit details
-
Copy full SHA for d604bc2 - Browse repository at this point
Copy the full SHA d604bc2View commit details -
Merge pull request #3 from oppia/develop
Develop (fork) Branch Update
Configuration menu - View commit details
-
Copy full SHA for cc0ddef - Browse repository at this point
Copy the full SHA cc0ddefView commit details
Commits on Aug 29, 2024
-
Merge pull request #4 from oppia/develop
Develop(fork) branch update
Configuration menu - View commit details
-
Copy full SHA for 52c6bb1 - Browse repository at this point
Copy the full SHA 52c6bb1View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 773c810 - Browse repository at this point
Copy the full SHA 773c810View commit details
Commits on Sep 16, 2024
-
Merge pull request #5 from oppia/develop
Develop (fork) Branch Update
Configuration menu - View commit details
-
Copy full SHA for 56af5ae - Browse repository at this point
Copy the full SHA 56af5aeView commit details
Commits on Sep 27, 2024
-
Merge pull request #6 from oppia/develop
Develop (fork) Branch Update
Configuration menu - View commit details
-
Copy full SHA for 3883f70 - Browse repository at this point
Copy the full SHA 3883f70View commit details
Commits on Oct 11, 2024
-
Fix oppia#5404: Migrate away from onBackPressed for remaining activit…
…ies (oppia#5526) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> Fixes oppia#5404 This PR migrates deprecated `onBackPressed` usage to `OnBackPressedDispatcher` callback in the following activities and presenters. - ProfileEditActivity - ProfileEditActivityPresenter - QuestionPlayerActivityPresenter - WalkthroughFinalFragmentPresenter ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing --------- Co-authored-by: Adhiambo Peres <[email protected]> Co-authored-by: Mr. 17 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 10c8e6e - Browse repository at this point
Copy the full SHA 10c8e6eView commit details -
Fix oppia#5404: Migrate away from onBackPressed for RevisionCardActiv…
…ity (oppia#5548) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> Fixes oppia#5404 This PR migrates deprecated `onBackPressed `usage to `OnBackPressedDispatcher` callback in the RevisonCardActivity and RevisionCardActivityPresenter. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Configuration menu - View commit details
-
Copy full SHA for 5e140e9 - Browse repository at this point
Copy the full SHA 5e140e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4ad7a3 - Browse repository at this point
Copy the full SHA b4ad7a3View commit details
Commits on Oct 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8d0328c - Browse repository at this point
Copy the full SHA 8d0328cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16230b7 - Browse repository at this point
Copy the full SHA 16230b7View commit details