-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5344: Fix Localization Issues of Classroom List Screen #5479
Conversation
This is required to ensure that the direction of the header is correct in RTL layouts
Hi @adhiamboperes, I've created this PR to fix the RTL layout issues. Could you please take a look at the latest screenshots and let me know if any further changes are required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @theMr17!
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
@theMr17, please sync branch and resolve conflicts. |
Done @adhiamboperes! |
Explanation
Fixes part of #5344
This PR fixes the localization issues of the promoted stories' header and the classroom carousel.
Screenshots
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: