Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2711 & part of #5343: Workflow cancellation support in CI using concurrency #5466

Merged
merged 21 commits into from
Jul 29, 2024

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    f1bafb2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1bd7dc0 View commit details
    Browse the repository at this point in the history
  3. Trigger #2 Triggering CI builds #1 worked as expected with 75% of wor…

    …kflows ran and 25% in progress and every in progress got cancelled on Trigger #1
    Rd4dev committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    9ea4511 View commit details
    Browse the repository at this point in the history
  4. Trigger #3 Triggering CI builds #2 worked as expected with 20% of wor…

    …kflows ran and 80% in progress and every in progress got cancelled on Trigger #2
    Rd4dev committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c215fdc View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…

    …o workflow_canceller_concurrency
    Rd4dev committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    66816be View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Configuration menu
    Copy the full SHA
    dc1ab3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef9f571 View commit details
    Browse the repository at this point in the history
  3. Trigger Build before Build App stage

    Triggering build after Build App at Utility test stage had the same behaviour of delaying the cut off and it even started the Data tests stage and stopped there
    Rd4dev committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    3398359 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0ee5f80 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2118891 View commit details
    Browse the repository at this point in the history
  6. Replacing always with !cancelled to not get affected by success and f…

    …ailure cases but still consider cancellations
    Rd4dev committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    e9c3d60 View commit details
    Browse the repository at this point in the history
  7. Triggering immediately after replacing always with !cancelled to see …

    …if they are getting properly cancelled
    Rd4dev committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    6f54fd0 View commit details
    Browse the repository at this point in the history
  8. Adding !cancelled to unit tests Check Results job while having a forc…

    …ed failure for TestFileCheck
    
    This should fail the test and eventually call the Check Result job inspite of the failure. If it does then the !cancelled is working as intended replacing always
    Rd4dev committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    11a0560 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5eabb1d View commit details
    Browse the repository at this point in the history
  10. Replacing all always expressions with !cancelled since the unit test …

    …Check Results calls did get triggered even after failure cases
    Rd4dev committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    20d9450 View commit details
    Browse the repository at this point in the history
  11. Triggering immediately after replacing every always expression to con…

    …firm the Non-app module steps too does work in the way it is desired to be
    Rd4dev committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    125d30e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    10778b9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6e5112f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e73ae04 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    076687e View commit details
    Browse the repository at this point in the history
  16. Triggering once again inbetween the previous check to confirm they ge…

    …t cancelled in progress properly
    Rd4dev committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    e9ebf29 View commit details
    Browse the repository at this point in the history