Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5406: Migrate keyboard hiding functionality #5463

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Fix #5406: Migrate keyboard hiding functionality #5463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65c9932
update deprecated InputMethodManager.SHOW_FORCED usage
subhajitxyz Jul 13, 2024
9cc6cf0
Merge branch 'develop' into fix/keyboard-hide-deprecation
subhajitxyz Jul 14, 2024
480d28c
Update SurveyFragmentPresenter.kt
subhajitxyz Jul 16, 2024
9fd1db7
Update app/src/main/java/org/oppia/android/app/player/state/StateFrag…
subhajitxyz Jul 16, 2024
f9b3c2d
Update QuestionPlayerFragmentPresenter.kt
subhajitxyz Jul 16, 2024
92fc4c1
Merge branch 'develop' into fix/keyboard-hide-deprecation
adhiamboperes Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/src/main/java/org/oppia/android/app/player/state/StateFragmentPresenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,8 @@ class StateFragmentPresenter @Inject constructor(
val inputManager: InputMethodManager =
activity.getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager
inputManager.hideSoftInputFromWindow(
fragment.view!!.windowToken,
@Suppress("DEPRECATION") // TODO(#5406): Use the correct constant value here.
InputMethodManager.SHOW_FORCED
fragment.requireView().windowToken,
0 // Flag value to force hide the keyboard when possible.
)
}

Expand Down
5 changes: 2 additions & 3 deletions app/src/main/java/org/oppia/android/app/survey/SurveyFragmentPresenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,8 @@ class SurveyFragmentPresenter @Inject constructor(
val inputManager: InputMethodManager =
activity.getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager
inputManager.hideSoftInputFromWindow(
fragment.view!!.windowToken,
@Suppress("DEPRECATION") // TODO(#5406): Use the correct constant value here.
InputMethodManager.SHOW_FORCED
fragment.requireView().windowToken,
0 // Flag value to force hide the keyboard when possible.
)
}

Expand Down
5 changes: 2 additions & 3 deletions ...c/main/java/org/oppia/android/app/topic/questionplayer/QuestionPlayerFragmentPresenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,8 @@ class QuestionPlayerFragmentPresenter @Inject constructor(
val inputManager: InputMethodManager =
activity.getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager
inputManager.hideSoftInputFromWindow(
fragment.view!!.windowToken,
@Suppress("DEPRECATION") // TODO(#5406): Use the correct constant value here.
InputMethodManager.SHOW_FORCED
fragment.requireView().windowToken,
0 // Flag value to force hide the keyboard when possible.
)
}

Expand Down
Loading