-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5344: Implement event logs for multiple classrooms #5456
Conversation
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 7280 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 8232 bytes (Added) Method count: 258445 (old), 258691 (new), 246 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6775 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 7276 bytes (Added) Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 3128 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 1568 bytes (Added) Method count: 114844 (old), 114906 (new), 62 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 3128 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 2984 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 3891 bytes (Added) Method count: 114850 (old), 114912 (new), 62 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 2988 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 2924 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 4209 bytes (Added) Method count: 114850 (old), 114912 (new), 62 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 2924 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
This PR is ready for a review, @adhiamboperes PTAL. |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 7684 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 8587 bytes (Added) Method count: 258445 (old), 258691 (new), 246 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6775 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 7680 bytes (Added) Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 3064 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 2232 bytes (Added) Method count: 114844 (old), 114908 (new), 64 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 3064 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 2972 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 5123 bytes (Added) Method count: 114850 (old), 114914 (new), 64 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 2976 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 3084 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 7273 bytes (Added) Method count: 114850 (old), 114914 (new), 64 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 3080 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
1 similar comment
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 7684 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 8587 bytes (Added) Method count: 258445 (old), 258691 (new), 246 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6775 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 7680 bytes (Added) Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 3064 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 2232 bytes (Added) Method count: 114844 (old), 114908 (new), 64 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 3064 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 2972 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 5123 bytes (Added) Method count: 114850 (old), 114914 (new), 64 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 2976 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 3084 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 7273 bytes (Added) Method count: 114850 (old), 114914 (new), 64 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5745 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 3080 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! PTAL at the comments.
app/src/main/java/org/oppia/android/app/classroom/ClassroomListActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/classroom/ClassroomListActivity.kt
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/exploration/ExplorationProgressController.kt
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/oppialogger/analytics/LearnerAnalyticsLogger.kt
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/player/exploration/ExplorationFragmentPresenter.kt
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/topic/TopicController.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt
Outdated
Show resolved
Hide resolved
Thanks @adhiamboperes! Addressed all the comments, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17. Just some minor follow ups.
domain/src/test/java/org/oppia/android/domain/classroom/ClassroomControllerTest.kt
Outdated
Show resolved
Hide resolved
testing/src/main/java/org/oppia/android/testing/logging/EventLogSubject.kt
Outdated
Show resolved
Hide resolved
Unassigning @adhiamboperes since the review is done. |
Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
@adhiamboperes PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17. This looks fairly good.
Unassigning @adhiamboperes since they have already approved the PR. |
To get this PR ready for merge, could you please add a video showing visiting the relevant screens to trigger the 3 highlighted event logs, then the developer options > eventlogs screen to show they were logged. This is for both flag on and off. |
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
@adhiamboperes PTAL, added the screen recordings per suggestion. |
LGTM, thanks! |
Explanation
Fixes part of #5344
open_home
&complete_app_onboarding
event logs are captured in the new screen.classroomId
field to theExplorationContext
object and updates related tests.start_exploration
event and adds tests.FeatureFlagLogger
with theENABLE_MULTIPLE_CLASSROOMS
feature flag.Screen Recording
Feature Flag On
FeatureFlagOn.mp4
Feature Flag Off
FeatureFlagOff.mp4
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: