Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #4120, part of #1051: Fix a lot of build-time warnings #5402

Merged
merged 149 commits into from
Jun 3, 2024

Commits on Mar 27, 2023

  1. Configuration menu
    Copy the full SHA
    9ca7e2b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7238b59 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Fix Maven license check & update the list.

    The check & related scripts required fairly involved reworking since the
    Maven install file (from which it sources Maven URL context) changed in
    format as part of the upgrade for rules_jvm_external. This has actually
    led to what seems to be more correct analysis of libraries that the
    build depends on, so more licenses have been added to the
    maven_dependencies.textproto tracking file.
    
    One unused Crashlytics dependency was removed since it was referencing
    an old license that doesn't exist anymore (and the artifact should be
    replaced in full by more recent Firebase Crashlytics dependencies that
    we are already using).
    BenHenning committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    f6188ac View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Fix issues with compute_affected_tests.

    This addresses an underlying bug with the command executor that can, in
    some cases, break compute_affected_tests. It also refines some of its
    internal mechanisms for much better performance on expensive PRs.
    
    It also prepares the base support needed for merge queues, but the
    CI workflows aren't being updated in this change.
    BenHenning committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2c3b6ea View commit details
    Browse the repository at this point in the history
  2. Use base SHA for computing affected tests.

    This prepares for merge queues (but doesn't quite configure the workflow
    for them--that will happen in a different PR), and improves how tests
    are computed for stacked PRs.
    BenHenning committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    c325bc9 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'upgrade-compute-affected-tests' into update-rules-jvm-e…

    …xternal
    
    Conflicts:
    	scripts/src/java/org/oppia/android/scripts/common/BUILD.bazel
    	scripts/src/java/org/oppia/android/scripts/license/MavenDependenciesListCheck.kt
    	scripts/src/java/org/oppia/android/scripts/license/MavenDependenciesRetriever.kt
    	scripts/src/java/org/oppia/android/scripts/maven/GenerateMavenDependenciesList.kt
    	scripts/src/javatests/org/oppia/android/scripts/license/MavenDependenciesListCheckTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/license/MavenDependenciesRetrieverTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/maven/GenerateMavenDependenciesListTest.kt
    BenHenning committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2012647 View commit details
    Browse the repository at this point in the history
  4. Post-merge lint fix.

    BenHenning committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    47f9c02 View commit details
    Browse the repository at this point in the history
  5. Fix updated TODOs.

    Also, update TODO check script to have nicer output, and support
    generating the exemption textproto file for easier updates in the
    future.
    BenHenning committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    8ae5aa8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    de3cf14 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Fix Dagger structure.

    This moves the codebase to using the recommended single top-level Dagger
    library rather than replicating it in a bunch of different places.
    BenHenning committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    b2ca68b View commit details
    Browse the repository at this point in the history
  2. Upgrade Dagger version.

    This is needed for downstream work. It also includes ensuring that Guava
    JRE can never be used (since only Android should ever be referenced by
    the production app build).
    BenHenning committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    839be0f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c2fe337 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a543500 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b882832 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. Configuration menu
    Copy the full SHA
    aaa0299 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d520fa9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    037be61 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Configuration menu
    Copy the full SHA
    8a19b4e View commit details
    Browse the repository at this point in the history
  2. Fix breakage from develop.

    The new proto target isn't used anywhere so this was missed.
    BenHenning committed May 11, 2023
    Configuration menu
    Copy the full SHA
    773f7ff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    311951f View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Configuration menu
    Copy the full SHA
    9e377d5 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Merge branch 'develop' into upgrade-compute-affected-tests

    Conflicts:
    	scripts/assets/todo_open_exemptions.textproto
    BenHenning committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    525a601 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'upgrade-compute-affected-tests' into update-rules-jvm-e…

    …xternal
    
    Conflicts:
    	scripts/assets/test_file_exemptions.textproto
    	third_party/maven_install.json
    BenHenning committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    6cca78f View commit details
    Browse the repository at this point in the history
  3. Post-merge fixes.

    BenHenning committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    327114d View commit details
    Browse the repository at this point in the history
  4. Merge branch 'update-rules-jvm-external' into update-dagger-structure

    Conflicts:
    	app/src/main/java/org/oppia/android/app/translation/BUILD.bazel
    	third_party/maven_install.json
    BenHenning committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    bb4ff28 View commit details
    Browse the repository at this point in the history
  5. Post-merge fixes.

    BenHenning committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    5d924f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Fix a variety of dev platform-specific issues.

    These issues were found after I started using a new development
    environment.
    BenHenning committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    667bf89 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Tidy some things up, and revert fragment test.

    ProfileAndDeviceIdFragmentTest had been updated to use a newer fragment
    initialization pattern, but that's no longer needed and seems to be
    causing what appears to be timing discrepancies between local dev and
    CI.
    BenHenning committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    fb59232 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Fix test behavior inconsistency in test.

    The issue ultimately arose from test parameters being initialized after
    they're needed in the launched UI. This type of change was tried earlier
    in the branch, but reverted since it didn't seem necessary. It is,
    however, necessary when there are environment differences (e.g. local
    vs. CI) or when running certain tests individually.
    
    Due to the difficulty in finding this issue, ActivityScenarioRule has
    been added as a prohibited pattern in the static regex checks (along
    with ActivityTestRule since that's deprecated and discouraged, anyway).
    BenHenning committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2551d4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    714f3ea View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Fix broken ProfileAndDeviceIdFragmentTest test.

    The test was suffering from some proto encoding inconsistencies that
    seem to occur between some development machines vs. on CI. The fix
    improves the test's robustness by extracting the raw encoded string,
    verifying that the other outputs in the intent message correctly
    correspond to that string, and that the string (as a parsed proto)
    contains the correct values. As a result, the test no longer depends on
    a hardcoded encoding value to be present for verification. This does
    result in a bit more logic than is generally good to have in a test (and
    it lengthened the test code quite a bit), but it seems necessary in this
    particular case.
    BenHenning committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7488b9f View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Configuration menu
    Copy the full SHA
    e3d4091 View commit details
    Browse the repository at this point in the history
  2. Post-merge fix.

    BenHenning committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    5671673 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'fix-platform-specific-issues' into upgrade-compute-affe…

    …cted-tests
    
    Conflicts:
    	scripts/assets/todo_open_exemptions.textproto
    	scripts/src/javatests/org/oppia/android/scripts/ci/ComputeAffectedTestsTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/common/GitClientTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/todo/TodoIssueResolvedCheckTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/todo/TodoOpenCheckTest.kt
    BenHenning committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f5ed0c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    bd1466d View commit details
    Browse the repository at this point in the history
  2. Merge branch 'fix-platform-specific-issues' into upgrade-compute-affe…

    …cted-tests
    
    Conflicts:
    	scripts/assets/todo_open_exemptions.textproto
    	scripts/src/javatests/org/oppia/android/scripts/ci/ComputeAffectedTestsTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/common/GitClientTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/todo/TodoIssueResolvedCheckTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/todo/TodoOpenCheckTest.kt
    BenHenning committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    d9b38ea View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Some follow-up post-merge fixes.

    This doesn't address all timeouts being observed in scripts. More
    analysis may be needed.
    BenHenning committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9f1a2ec View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Make TodoOpenCheck locally runnable.

    This does a bunch of other small things, too, but the main difference
    here is introducing support for interacting with GitHub via its REST API
    rather than requiring the user to use the 'gh' tool locally (though the
    gh CLI tool is still needed for maintaining authentication access).
    BenHenning committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    39a3add View commit details
    Browse the repository at this point in the history
  2. Simplify GitHubIssue & some static fixes/docs.

    Tests still need to be added, and some cleanup is needed once the
    branch's base is adjusted.
    BenHenning committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    4f7bfd6 View commit details
    Browse the repository at this point in the history
  3. Add ScriptBackgroundCoroutineDispatcher.

    This is a script-specific dispatcher which will allow for better
    asynchronous support in upcoming PRs (especially for command execution).
    This change serves to prepare for those changes.
    BenHenning committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    000bba3 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Some more robustness fixes.

    The main change here is ensuring that Bazel 4.0.0 is used & bzlmod
    disabled in newer versions of Bazel when running operations in a test
    Bazel environment.
    
    This commit also introduces some more timing tweaks on CommandExecutor
    for some tests, though these only affect very specific tests (as many
    script tests directly call a script's main() function and thus don't
    overwrite its executor behavior).
    
    This commit attempted to introduce "--batch" mode to runs, but the
    isolation didn't actually seem to improve stability and, instead,
    substantially slowed down some of the tests.
    BenHenning committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    79878cd View commit details
    Browse the repository at this point in the history
  2. Merge branch 'fix-platform-specific-issues' into introduce-better-scr…

    …ipt-execution-support
    
    Conflicts:
    	scripts/src/java/org/oppia/android/scripts/ci/ComputeAffectedTests.kt
    	scripts/src/javatests/org/oppia/android/scripts/ci/ComputeAffectedTestsTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/common/BazelClientTest.kt
    BenHenning committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    a5f71d6 View commit details
    Browse the repository at this point in the history
  3. Post-merge fixes.

    Plus, actually makes use of the new script background dispatcher in
    CommandExecutorImpl to make the new wiring make more sense (though its
    real utility will come in a follow-up PR).
    BenHenning committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0b55bd4 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    53d6727 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Post-merge fixes & adjustments.

    This makes the TODO open check script runnable using the script
    background dispatcher, and fixes some tests so that they pass now.
    
    More documentation and testing work is still needed to finalize this PR.
    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    00c7c28 View commit details
    Browse the repository at this point in the history
  2. Fix BUILD file lint issue.

    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    bd97611 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d54829d View commit details
    Browse the repository at this point in the history
  4. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    fa9cae4 View commit details
    Browse the repository at this point in the history
  5. Static fix checks.

    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    0618b12 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'make-todo-check-locally-runnable' into upgrade-compute-…

    …affected-tests
    
    Conflicts:
    	scripts/assets/todo_open_exemptions.textproto
    	scripts/src/java/org/oppia/android/scripts/ci/ComputeAffectedTests.kt
    	scripts/src/java/org/oppia/android/scripts/common/BazelClient.kt
    	scripts/src/java/org/oppia/android/scripts/common/CommandExecutorImpl.kt
    	scripts/src/java/org/oppia/android/scripts/common/GitClient.kt
    	scripts/src/java/org/oppia/android/scripts/todo/BUILD.bazel
    	scripts/src/java/org/oppia/android/scripts/todo/TodoOpenCheck.kt
    	scripts/src/javatests/org/oppia/android/scripts/ci/ComputeAffectedTestsTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/common/ScriptBackgroundCoroutineDispatcherTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/testing/TestGitRepositoryTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/todo/TodoIssueResolvedCheckTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/todo/TodoOpenCheckTest.kt
    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    fb148ea View commit details
    Browse the repository at this point in the history
  7. Post-merge fixes.

    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    ab326ff View commit details
    Browse the repository at this point in the history
  8. Merge branch 'upgrade-compute-affected-tests' of github.com:oppia/opp…

    …ia-android into upgrade-compute-affected-tests
    
    Conflicts:
    	scripts/assets/todo_open_exemptions.textproto
    	scripts/src/java/org/oppia/android/scripts/testing/TestBazelWorkspace.kt
    	scripts/src/javatests/org/oppia/android/scripts/todo/TodoOpenCheckTest.kt
    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    d5bfad5 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'upgrade-compute-affected-tests' into update-rules-jvm-e…

    …xternal
    
    Conflicts:
    	scripts/assets/test_file_exemptions.textproto
    	scripts/src/javatests/org/oppia/android/scripts/maven/RetrieveLicenseTextsTest.kt
    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    1067a18 View commit details
    Browse the repository at this point in the history
  10. Post-merge fixes.

    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    1e2df14 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Configuration menu
    Copy the full SHA
    211487c View commit details
    Browse the repository at this point in the history
  2. Post-merge fixes.

    BenHenning committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1a666a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    a2ee5d3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d5b9012 View commit details
    Browse the repository at this point in the history
  3. Fixed broken instrumentation builds.

    This was done by removing the //testing dependency and, instead, having
    instrumentation targets depend on the direct module within //testing
    that they need to build. This module & its corresponding implementation
    binding (and tests) needed to be moved out of //testing and into their
    own /firebase package.
    BenHenning committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e6ec869 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f50469 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8dbf4dc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9c38057 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f2ff4e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Add missing tests for TestBlazeWorkspace changes.

    Also includes some minor clean-ups within TestBazelWorkspaceTest.
    BenHenning committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    fad48ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e1802c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00c32f6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f87f4d View commit details
    Browse the repository at this point in the history
  5. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    aa3547c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d3cbd93 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    13e4358 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    622aced View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    50f41d2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c8df70e View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    c85d421 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dcf27b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2369514 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c7ec5d4 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4b418bd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d6a9f70 View commit details
    Browse the repository at this point in the history
  7. Improve new test robustness.

    Required upgrade of kotlinx-coroutines-core.
    BenHenning committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    8de4d51 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3f69f11 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ea8e0b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Update scripts/src/javatests/org/oppia/android/scripts/common/GitClie…

    …ntTest.kt
    
    Co-authored-by: Adhiambo Peres <[email protected]>
    BenHenning and adhiamboperes authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2916770 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f2d810a View commit details
    Browse the repository at this point in the history
  3. Merge branch 'fix-platform-specific-issues' into introduce-better-scr…

    …ipt-execution-support
    
    Conflicts:
    	third_party/maven_install.json
    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    808f412 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2315aea View commit details
    Browse the repository at this point in the history
  5. Add tests for GitHubClient & TodoOpenCheck.

    Add new FakeCommandExecutor utility + tests.
    
    Add missing GitHub workflow update.
    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    af51395 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6856e3c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5a050de View commit details
    Browse the repository at this point in the history
  8. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    13b8d4b View commit details
    Browse the repository at this point in the history
  9. Add missing docs.

    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    280b3ec View commit details
    Browse the repository at this point in the history
  10. Merge branch 'make-todo-check-locally-runnable' into upgrade-compute-…

    …affected-tests
    
    Conflicts:
    	scripts/assets/todo_open_exemptions.textproto
    	scripts/src/javatests/org/oppia/android/scripts/todo/TodoOpenCheckTest.kt
    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0bd7e2f View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Post-merge fixes.

    BenHenning committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    5951c0f View commit details
    Browse the repository at this point in the history
  2. Merge branch 'upgrade-compute-affected-tests' into update-rules-jvm-e…

    …xternal
    
    Conflicts:
    	scripts/assets/maven_dependencies.textproto
    	third_party/maven_install.json
    BenHenning committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ee71b32 View commit details
    Browse the repository at this point in the history
  3. Update Maven dep list checker & updater scripts.

    Updates the utilities for the Maven dep list & updater scripts to have
    much more robustness when trying to verify the correct repository URLs
    for artifact coordinates, and when downloading artifact POM files. The
    main robustness changes come in the form of retries and smarter
    parallelization and error checking.
    
    These changes were necessary due to one of my workstations frequently
    flaking out on large numbers of URL blocks during verification, and this
    helps considerably.
    BenHenning committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    3627067 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Configuration menu
    Copy the full SHA
    a5eb624 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ae239b3 View commit details
    Browse the repository at this point in the history
  3. Fix broken TodoOpenCheck tests & check exemptions.

    For the former, this mainly involved isolating the gh auth tool
    dependency in the same way as GitHubClientTest. This improves
    environment independence and test performance.
    BenHenning committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    34ea6aa View commit details
    Browse the repository at this point in the history
  4. Merge branch 'make-todo-check-locally-runnable' into upgrade-compute-…

    …affected-tests
    
    Conflicts:
    	scripts/assets/todo_open_exemptions.textproto
    	scripts/src/javatests/org/oppia/android/scripts/todo/TodoOpenCheckTest.kt
    BenHenning committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    df61985 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    161ae8d View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Configuration menu
    Copy the full SHA
    8c87993 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'update-rules-jvm-external' into update-dagger-structure

    Includes some manual fixes due to ":dagger" being moved to top-level.
    
    Conflicts:
    	app/BUILD.bazel
    	app/src/main/java/org/oppia/android/app/notice/testing/BUILD.bazel
    	app/src/sharedTest/java/org/oppia/android/app/notice/BUILD.bazel
    	domain/src/main/java/org/oppia/android/domain/onboarding/BUILD.bazel
    	domain/src/main/java/org/oppia/android/domain/oppialogger/analytics/BUILD.bazel
    	domain/src/test/java/org/oppia/android/domain/exploration/BUILD.bazel
    	domain/src/test/java/org/oppia/android/domain/onboarding/BUILD.bazel
    	domain/src/test/java/org/oppia/android/domain/oppialogger/analytics/BUILD.bazel
    	scripts/assets/maven_dependencies.textproto
    	third_party/maven_install.json
    	third_party/versions.bzl
    	utility/src/main/java/org/oppia/android/util/logging/firebase/BUILD.bazel
    	utility/src/test/java/org/oppia/android/util/logging/firebase/BUILD.bazel
    BenHenning committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    bb6e681 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Configuration menu
    Copy the full SHA
    5c812a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    e0e74d5 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    2dd0cd7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    79a2f0f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    60458bf View commit details
    Browse the repository at this point in the history
  5. Merge branch 'update-rules-jvm-external' into update-dagger-structure

    Conflicts:
    	utility/src/main/java/org/oppia/android/util/locale/BUILD.bazel
    BenHenning committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    228a037 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    70df9b3 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    04fc8b8 View commit details
    Browse the repository at this point in the history
  3. Address reviewer comment.

    BenHenning committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c301eed View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Configuration menu
    Copy the full SHA
    51a96ce View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Merge commit 'e2f94e41e4cba3bc5b5f3af65f7c43a6543b4c52' into introduc…

    …e-better-script-execution-support
    BenHenning committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b3e2fd9 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    73a8bce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f48f78e View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    02ccc87 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    28fcb9d View commit details
    Browse the repository at this point in the history
  3. Merge branch 'upgrade-compute-affected-tests' into update-rules-jvm-e…

    …xternal
    
    Conflicts:
    	WORKSPACE
    	third_party/maven_install.json
    BenHenning committed May 16, 2024
    Configuration menu
    Copy the full SHA
    aa8988c View commit details
    Browse the repository at this point in the history
  4. Merge branch 'update-rules-jvm-external' into update-dagger-structure

    Conflicts:
    	domain/src/main/java/org/oppia/android/domain/oppialogger/analytics/BUILD.bazel
    	third_party/maven_install.json
    	utility/src/test/java/org/oppia/android/util/logging/BUILD.bazel
    BenHenning committed May 16, 2024
    Configuration menu
    Copy the full SHA
    658c9f0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4cf06d4 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    0cc5d5d View commit details
    Browse the repository at this point in the history
  2. Address review comment.

    BenHenning committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c43c036 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'update-rules-jvm-external' into update-dagger-structure

    Conflicts:
    	third_party/maven_install.json
    BenHenning committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c30a839 View commit details
    Browse the repository at this point in the history
  4. Post-merge fixes.

    BenHenning committed May 17, 2024
    Configuration menu
    Copy the full SHA
    fbac9a2 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Upgrade to rules_kotlin 1.5.0 beta 3.

    This is in preparation for the codebase-wide upgrade to Kotlin 1.6.
    BenHenning committed May 21, 2024
    Configuration menu
    Copy the full SHA
    956b358 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Fix build-time Kotlin & Java warnings.

    This pulls in non-configuration changes from #4937 that are compatible with the
    current Kotlin 1.4.x. Kotlin 1.5 and 1.6 changes will need to come as part of a
    downstream PR.
    BenHenning committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f5c07fc View commit details
    Browse the repository at this point in the history
  2. Fix a few follow-up issues.

    These are mainly reverting a few more Kotlin 1.5/1.6-specific API
    changes.
    BenHenning committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0429177 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3dc6b7b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    acd1c0d View commit details
    Browse the repository at this point in the history
  5. Address reviewer comment.

    BenHenning committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c672af0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1b19f5b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3e923e2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9af41bd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6100394 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b6c3ebe View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Move forward TODO fixes from #4937.

    These changes should have been in this branch originally.
    BenHenning committed May 23, 2024
    Configuration menu
    Copy the full SHA
    441e293 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f1eed7 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Configuration menu
    Copy the full SHA
    785d408 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7951d46 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Configuration menu
    Copy the full SHA
    d4d8646 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b6cfd74 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0468e81 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    47ad078 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    828e43e View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Configuration menu
    Copy the full SHA
    7c186c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dffff83 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Address review comment.

    BenHenning committed May 29, 2024
    Configuration menu
    Copy the full SHA
    bc79bf7 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'develop' into fix-build-time-kotlin-java-warnings

    Conflicts:
    	domain/src/main/java/org/oppia/android/domain/topic/PrimeTopicAssetsControllerImpl.kt
    BenHenning committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2d3f5d5 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Configuration menu
    Copy the full SHA
    4b26fd5 View commit details
    Browse the repository at this point in the history