Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2536: Introduce a central utility for matching item in RecyclerView #5391

Merged

Conversation

deonwaju
Copy link
Collaborator

@deonwaju deonwaju commented Apr 28, 2024

Explanation

Fix #2536

I worked on the below functions renaming the title and adding an argument for the recyclerviewId to each function to make it reusable, I also added kdocs to help understand the functions.
P.S:- I created the functions in the RecyclerviewMatcher class.

Screenshot 2024-04-30 at 01 24 45

Screenshot 2024-04-30 at 01 24 26

Screenshot 2024-04-30 at 01 24 57

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@deonwaju deonwaju requested a review from a team as a code owner April 28, 2024 12:42
@deonwaju
Copy link
Collaborator Author

PTAL @adhiamboperes

@oppiabot oppiabot bot assigned adhiamboperes and unassigned deonwaju Apr 30, 2024
Copy link

oppiabot bot commented Apr 30, 2024

Unassigning @deonwaju since a re-review was requested. @deonwaju, please make sure you have addressed all review comments. Thanks!

Copy link

oppiabot bot commented May 7, 2024

Hi @deonwaju, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 7, 2024
@Vishwajith-Shettigar Vishwajith-Shettigar removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 8, 2024
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deonwaju!

Juat one minor comment but the rest LGTM.

@deonwaju
Copy link
Collaborator Author

deonwaju commented May 8, 2024

PTAL @adhiamboperes

@oppiabot oppiabot bot assigned adhiamboperes and unassigned deonwaju May 8, 2024
Copy link

oppiabot bot commented May 8, 2024

Unassigning @deonwaju since a re-review was requested. @deonwaju, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @deonwaju.

@adhiamboperes adhiamboperes merged commit a818170 into oppia:develop May 8, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a central utility for matching item in RecyclerView [Testing]
3 participants