-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2536: Introduce a central utility for matching item in RecyclerView #5391
Fix #2536: Introduce a central utility for matching item in RecyclerView #5391
Conversation
…RecyclerViewMatcher.kt
…RecyclerViewMatcher.kt
PTAL @adhiamboperes |
Hi @deonwaju, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @deonwaju!
Juat one minor comment but the rest LGTM.
app/src/sharedTest/java/org/oppia/android/app/recyclerview/RecyclerViewMatcher.kt
Outdated
Show resolved
Hide resolved
PTAL @adhiamboperes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @deonwaju.
Explanation
Fix #2536
I worked on the below functions renaming the title and adding an argument for the recyclerviewId to each function to make it reusable, I also added kdocs to help understand the functions.
P.S:- I created the functions in the RecyclerviewMatcher class.
Essential Checklist