-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Part of #4938: Introduce Create profile screen #5380
Conversation
…boarding-profile-type-screen
…boarding-profile-type-screen # Conflicts: # app/src/main/res/values/component_colors.xml # scripts/assets/test_file_exemptions.textproto
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 14 MiB (old), 15 MiB (new), 34 KiB (Added) Method count: 221945 (old), 222144 (new), 199 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 40 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9232 KiB (old), 9265 KiB (new), 33 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 39 KiB (Added) APK download size (estimated): 9218 KiB (old), 9251 KiB (new), 32 KiB (Added) Method count: 99526 (old), 99642 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 39 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
# Conflicts: # scripts/assets/test_file_exemptions.textproto
# Conflicts: # scripts/assets/test_file_exemptions.textproto
@seanlip, @ashley-ya, and @malee04!, @BenHenning, Here are some attempts to incorporate the feedback. Could you please let me know which direction to lean towards?
|
Thanks @adhiamboperes! Personally, I like the second one best (highest contrast), followed by the third one, followed by the first. @ashley-ya @malee04 @BenHenning WDYT? |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
4 similar comments
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
I like the second option as well! the medium font with light background. |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added) APK download size (estimated): 15 MiB (old), 15 MiB (new), 35 KiB (Added) Method count: 227042 (old), 227243 (new), 201 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6586 (old), 6628 (new), 42 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 16 MiB (new), 41 KiB (Added)
Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 80 bytes (Added) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 103 KiB (old), 103 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 60 bytes (Added) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 100 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9267 KiB (old), 9299 KiB (new), 32 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 38 KiB (Added) APK download size (estimated): 9253 KiB (old), 9285 KiB (new), 31 KiB (Added) Method count: 101431 (old), 101547 (new), 116 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5539 (old), 5585 (new), 46 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 38 KiB (Added)
Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 36 bytes (Added) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 48 bytes (Added) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 48 bytes (Added) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 60 bytes (Added) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 36 bytes (Added) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 48 bytes (Added) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 60 bytes (Added) |
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/org/oppia/android/app/activity/ActivityComponentImpl.kt # app/src/main/java/org/oppia/android/app/fragment/FragmentComponentImpl.kt # app/src/main/res/values-night/color_palette.xml # app/src/main/res/values/color_defs.xml # app/src/main/res/values/color_palette.xml # app/src/main/res/values/component_colors.xml # model/src/main/proto/screens.proto # utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/org/oppia/android/app/activity/ActivityComponentImpl.kt # app/src/main/java/org/oppia/android/app/fragment/FragmentComponentImpl.kt # app/src/main/java/org/oppia/android/app/onboarding/OnboardingProfileTypeFragmentPresenter.kt # app/src/main/res/values-night/color_palette.xml # app/src/main/res/values/color_palette.xml # app/src/main/res/values/component_colors.xml # app/src/main/res/values/strings.xml # app/src/main/res/values/styles.xml # app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingProfileTypeFragmentTest.kt # model/src/main/proto/screens.proto # scripts/assets/test_file_exemptions.textproto # utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt
Fixed the layouts with "option 2", and updated PR screenshots. There are no other pending comments, so enabling auto-merge. |
Explanation
Fix Part of #4938: Add a new Activity and associated Fragments and Presenters to allow a new learner to create a profile.
This does not include domain changes.
Placeholder tests have been added to ensure navigation tests are not forgotten. These will fail once navigation has been implemented.
Essential Checklist
For UI-specific PRs only
All Tests Passing on Espresso