Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPS Survey Gating #5356

Merged
merged 19 commits into from
Apr 6, 2024
Merged

Fix NPS Survey Gating #5356

merged 19 commits into from
Apr 6, 2024

Commits on Mar 11, 2024

  1. Remove observer after gating result is returned

    @adhiamboperes
    adhiamboperes committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    24e8b10 View commit details
    Browse the repository at this point in the history

  2. Minor update to syntax

    @adhiamboperes
    adhiamboperes committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    a3e4a97 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. fix flaky test

    @adhiamboperes
    adhiamboperes committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    1233d2b View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Add survey popup tests

    @adhiamboperes
    adhiamboperes committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d750e56 View commit details
    Browse the repository at this point in the history

  2. Disable robolectric runs as drag and drop interaction won't work, as … 

    …documented in #1612
    @adhiamboperes
    adhiamboperes committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    152d157 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Additional tests for the SurveyGatingController

    @adhiamboperes
    adhiamboperes committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a257c56 View commit details
    Browse the repository at this point in the history

  2. Remove unused parameter

    @adhiamboperes
    adhiamboperes committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a1f440b View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Improve tests

    @adhiamboperes
    adhiamboperes committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    f4f85f6 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Fix failing test

    @adhiamboperes
    adhiamboperes committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    848fc1d View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Add tests for updating underlying gating dataproviders

    @adhiamboperes
    adhiamboperes committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6376d65 View commit details
    Browse the repository at this point in the history

  2. Add tests for updating underlying gating dataproviders

    @adhiamboperes
    adhiamboperes committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b8ef774 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/fix-survey-gating' into fix-su… 

    …rvey-gating

# Conflicts:
#	app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt
    @adhiamboperes
    adhiamboperes committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    5dca4e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Fix failing tests

    @adhiamboperes
    adhiamboperes committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1f4b57e View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Add test for data provider update behaviour

    @adhiamboperes
    adhiamboperes committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f2914e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Clean up PR

    @adhiamboperes
    adhiamboperes committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0c3ce2f View commit details
    Browse the repository at this point in the history

  2. Remove redundant var

    @adhiamboperes
    adhiamboperes committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    26826e2 View commit details
    Browse the repository at this point in the history

  3. Revert idling resource changes

    @adhiamboperes
    adhiamboperes committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    17e5ee4 View commit details
    Browse the repository at this point in the history

  4. Remove formatting only changes

    @adhiamboperes
    adhiamboperes committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    35e36e9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into fix-survey-gating

    @adhiamboperes
    adhiamboperes authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a5d207f View commit details
    Browse the repository at this point in the history