Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FAQ Strings #5347

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Rename FAQ Strings #5347

merged 6 commits into from
Mar 1, 2024

Conversation

adhiamboperes
Copy link
Collaborator

@adhiamboperes adhiamboperes commented Feb 22, 2024

Explanation

Renamed FAQ question and answer strings from index-based to more descriptive qualifiers.
The corresponding translations to the previous strings have been deleted.
The goal is to to overwrite existing faq strings and re-translate them, since a number of updates were made in #5246 and #5332.

device-2024-02-22-030542.webm

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Also deleted existing translations for faq strings
@adhiamboperes adhiamboperes requested a review from a team as a code owner February 22, 2024 00:01
@adhiamboperes adhiamboperes self-assigned this Feb 22, 2024
@adhiamboperes
Copy link
Collaborator Author

Waiting for CI to pass but LGTM from self-review.

@adhiamboperes
Copy link
Collaborator Author

@BenHenning, PTAL.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adhiamboperes! This LGTM.

@BenHenning BenHenning enabled auto-merge (squash) February 23, 2024 01:16
@BenHenning
Copy link
Member

NB: The translated strings are okay to delete since much of the content has changed/moved around, so we're just going to require a re-translation of all of them. This does mean that the next app release may distribute these strings in English.

@seanlip do you see any need for us to block on FAQ translations for release 0.13?

Copy link

oppiabot bot commented Feb 23, 2024

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Feb 23, 2024
Copy link

oppiabot bot commented Feb 23, 2024

Hi @adhiamboperes, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@seanlip
Copy link
Member

seanlip commented Feb 23, 2024

NB: The translated strings are okay to delete since much of the content has changed/moved around, so we're just going to require a re-translation of all of them. This does mean that the next app release may distribute these strings in English.

@seanlip do you see any need for us to block on FAQ translations for release 0.13?

Thanks -- I think no need to block since I suspect this is a low-frequency screen. However I would like to ask if we could keep the existing translations for content whose ID has been renamed but the content itself has not changed, to minimize unnecessary translation work?

@BenHenning
Copy link
Member

BenHenning commented Feb 28, 2024

NB: The translated strings are okay to delete since much of the content has changed/moved around, so we're just going to require a re-translation of all of them. This does mean that the next app release may distribute these strings in English.
@seanlip do you see any need for us to block on FAQ translations for release 0.13?

Thanks -- I think no need to block since I suspect this is a low-frequency screen. However I would like to ask if we could keep the existing translations for content whose ID has been renamed but the content itself has not changed, to minimize unnecessary translation work?

I do believe this requires us to edit the strings directly in TranslateWiki, doesn't it @seanlip? Whenever we directly check in translated strings they get overwritten by TranslateWiki (though I don't recall if we've ever tried this for new strings, so it may work for those).

Edit: Also, if there's a way we can communicate the old strings to translators that might be easier for us. I'm not familiar with all the changes that were done to the English strings, so it may be possible that some only require small translation adjustments.

@BenHenning BenHenning assigned seanlip and unassigned BenHenning Feb 28, 2024
@seanlip
Copy link
Member

seanlip commented Feb 28, 2024

I do believe this requires us to edit the strings directly in TranslateWiki, doesn't it @seanlip? Whenever we directly check in translated strings they get overwritten by TranslateWiki (though I don't recall if we've ever tried this for new strings, so it may work for those).

@BenHenning Honestly I don't know. I think I'd suggest just doing it and seeing what happens, but I'm also fine either way.

Not sure of any direct way to communicate the old strings to translators, sorry.

@seanlip seanlip assigned BenHenning and unassigned seanlip Feb 28, 2024
@BenHenning
Copy link
Member

I do believe this requires us to edit the strings directly in TranslateWiki, doesn't it @seanlip? Whenever we directly check in translated strings they get overwritten by TranslateWiki (though I don't recall if we've ever tried this for new strings, so it may work for those).

@BenHenning Honestly I don't know. I think I'd suggest just doing it and seeing what happens, but I'm also fine either way.

Not sure of any direct way to communicate the old strings to translators, sorry.

@adhiamboperes WDYT about trying to manually copy in the translations based on:

  • The mapping of old strings names to new strings names.
  • The old English strings which didn't change (only these translations should be retained).

Do you think this could be done?

@BenHenning BenHenning removed their assignment Mar 1, 2024
@adhiamboperes
Copy link
Collaborator Author

@BenHenning, I have brought back the translations. PTAL.

@BenHenning BenHenning merged commit 0911e71 into develop Mar 1, 2024
36 checks passed
@BenHenning BenHenning deleted the fix-faq-strings branch March 1, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants