Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated new onboarding criteria #5337

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Updated new onboarding criteria #5337

merged 3 commits into from
Feb 9, 2024

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Feb 8, 2024

Explanation

Updated new onboarding criteria because sometimes 2 PRs can be small changes. And sometimes the contributor does not communicate well and will disappear soon. With that we see more new contributors so that we can keep growing the team, under the stricter acceptance criteria.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes PTAL, Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121 LGTM.

Copy link

oppiabot bot commented Feb 9, 2024

Assigning @BenHenning for code owner reviews. Thanks!

@adhiamboperes adhiamboperes merged commit 4a07d8d into oppia:develop Feb 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants