Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5143: Update Robolectric to 4.7 #5322

Closed
wants to merge 3 commits into from
Closed

Fix #5143: Update Robolectric to 4.7 #5322

wants to merge 3 commits into from

Conversation

sandy99405
Copy link

@sandy99405 sandy99405 commented Jan 26, 2024

Explanation

According to issue #5143, there was an error unexpected element <queries> found in <manifest> during the Bazel build.
That issue has been resolved in this PR.

  1. Robolectric version has been changed to 4.7 and espresso-core to 3.5.0-alpha03 in every build.gadle file

  2. In scripts/assets folder, the maven_dependencies.textproto file has been changed due to an exception.

This is the Bazel output after updating the Robolectric to 4.7 and maven_install

image

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link

Hi! @sandy99405 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandy99405!

  1. Could you please also update the robolectric versions in thebuild.gradlefiles for app, domain, utility and testing modules?
  2. The PR description has a checklist of what the PR should look like, mainly the Explanation bit and the title bit. Could you ensure this PR is compliant? You can copy the template from a different PR like Fix part of #5070: Display empty answer message in number input interaction #5310

@sandy99405
Copy link
Author

@adhiamboperes can you kindly confirm if I have to change Robolectric version in data and maven_install.json as well?

@adhiamboperes
Copy link
Collaborator

@adhiamboperes can you kindly confirm if I have to change Robolectric version in data and maven_install.json as well?

Yes, in data too. You can search each of the build.gradle files for ocurrances of robolectric and espresso-core to make sure you don't miss anything.

maven_install.json is specific to bazel and it is never updated manually -- it uses the update script that you previously ran.

@sandy99405
Copy link
Author

Thank you for the confirmation @adhiamboperes 👍

@sandy99405
Copy link
Author

@adhiamboperes , may I close this PR and create a new one? Because I erased all the rules before writing the comment and I don't know where to find the checklist rules. Please help

@adhiamboperes
Copy link
Collaborator

@adhiamboperes , may I close this PR and create a new one? Because I erased all the rules before writing the comment and I don't know where to find the checklist rules. Please help

Please copy the template from here: https://github.com/oppia/oppia-android/blob/develop/.github/PULL_REQUEST_TEMPLATE.md?plain=1

@sandy99405 sandy99405 changed the title Update Robolectric to 4.7 Fix #5143: Update Robolectric to 4.7 Jan 26, 2024
Signed-off-by: sandy99405 <[email protected]>
@sandy99405
Copy link
Author

All the changes are done @adhiamboperes. BTW the git-hub actions asked me to fill out the CLA sheet only then the PR will be accepted. It's this form right? Do I have to talk to you guys and stuff after filling out the form?

@sandy99405
Copy link
Author

Hi @adhiamboperes all the conflicts and updates have been finished. Please check this PR.

@sandy99405 sandy99405 closed this Jan 30, 2024
@sandy99405 sandy99405 deleted the new_branch branch January 30, 2024 10:16
@sandy99405 sandy99405 restored the new_branch branch January 30, 2024 10:16
@sandy99405 sandy99405 deleted the new_branch branch January 30, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants