Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5243: Technical Analytics Milestone 3 - New App Health Metrics #5320

Merged

Conversation

kkmurerwa
Copy link
Collaborator

@kkmurerwa kkmurerwa commented Jan 23, 2024

Explanation

Fixes #5243: When merged, this PR will;

  • Introduce the ability to log all network calls as well as failed network calls.
  • Introduce the ability to log all console errors logged via the ConsoleLogger.
  • Introduce the ability to log the time spent by a user with the app in the foreground.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@kkmurerwa kkmurerwa changed the title Technical analytics milestone 3 Technical Analytics: Milestone 3 - Add Onboarding, Network, and Console Error Logs to Firebase Jan 23, 2024
@kkmurerwa kkmurerwa self-assigned this Jan 23, 2024
@kkmurerwa kkmurerwa changed the title Technical Analytics: Milestone 3 - Add Onboarding, Network, and Console Error Logs to Firebase Technical Analytics: Milestone 3 - New App Health Metrics Jan 30, 2024
@kkmurerwa kkmurerwa marked this pull request as ready for review January 30, 2024 18:14
@kkmurerwa kkmurerwa requested review from a team as code owners January 30, 2024 18:14
@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa Mar 6, 2024
Copy link

oppiabot bot commented Mar 13, 2024

Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 13, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 13, 2024
Copy link

oppiabot bot commented Mar 20, 2024

Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 20, 2024
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa! I left a couple of minor comments, but I would still like you to further change the network test names. Please see inline.

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 20, 2024
@kkmurerwa
Copy link
Collaborator Author

Hi @adhiamboperes. I have made the changes suggested. PTAL

@oppiabot oppiabot bot assigned adhiamboperes and unassigned kkmurerwa Apr 1, 2024
Copy link

oppiabot bot commented Apr 1, 2024

Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa! LGTM.

Please address the remaining comment before merge.

@oppiabot oppiabot bot added the PR: LGTM label Apr 2, 2024
Copy link

oppiabot bot commented Apr 2, 2024

Hi @kkmurerwa, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes merged commit bf80719 into oppia:develop Apr 9, 2024
41 checks passed
@kkmurerwa kkmurerwa changed the title Technical Analytics: Milestone 3 - New App Health Metrics Fix #5243: Technical Analytics Milestone 3 - New App Health Metrics Aug 6, 2024
@kkmurerwa kkmurerwa changed the title Fix #5243: Technical Analytics Milestone 3 - New App Health Metrics Fixes #5243: Technical Analytics Milestone 3 - New App Health Metrics Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Implementation Request: Add new App Health Metrics
2 participants