-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5070: Display empty answer message in selection interaction #5319
Fix part of #5070: Display empty answer message in selection interaction #5319
Conversation
@adhiamboperes PTAL |
Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! I only have a monor non-blocking comment on this.
.../main/java/org/oppia/android/app/player/state/itemviewmodel/SelectionInteractionViewModel.kt
Outdated
Show resolved
Hide resolved
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
@adhiamboperes PTAL. |
Explanation
Fixes part of #5070
Enables the
submit_answer_button
when the pending answer is empty. Instead of disabling the button, an error message, stating "Choose an answer to continue.", is now displayed when the user attempts to submit without selecting any input.Screen.Recording.mp4
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: