Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5261: Unused Quantity #5318

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

deonwaju
Copy link
Collaborator

Fix part of #5261

Remove quantity zero from pt-rBR/strings.xml: line 208 []
Do the same for line 203

Explanation

Before:

Screenshot 2024-01-20 at 21 07 05

After:

Screenshot 2024-01-20 at 22 09 41

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@deonwaju deonwaju requested a review from a team as a code owner January 22, 2024 12:15
@deonwaju
Copy link
Collaborator Author

PTAL @adhiamboperes

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @deonwaju!

@adhiamboperes adhiamboperes enabled auto-merge (squash) January 22, 2024 22:28
Copy link

oppiabot bot commented Jan 22, 2024

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jan 22, 2024
Copy link

oppiabot bot commented Jan 22, 2024

Hi @deonwaju, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes merged commit 1892b15 into oppia:develop Jan 22, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants