-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4710 Resume Lesson Fragment Button Responsiveness, Icon Layout, and Dark Mode Color #5116
Conversation
…tton text and icon, fix button style not applied"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XichengSpencer LGTM, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @XichengSpencer. The PR looks good to me. I have a few issues with the PR title and description. The title could use some more explanation. Something like Fix #4710: Button Scaling and Dark Mode issues on Resume Lesson Fragment
. The description should give a general explanation of the changes the fix makes. See PR #5098, #5115, and #5111 for reference.
Hi @XichengSpencer, is this PR ready for my review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @XichengSpencer!
This LGTM.
Hi @XichengSpencer, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Fix #4710 the button scaling problem in largest text setting in the resume fragment, and fix the color change in dark mode.
The use of material button has better control for the icon inside the button so that it can group icons and text together as responsive design guidelines suggested. Particularly the icon gravity part that attached the icon to the text. Also, add flex layout so that button will wrap to two lines when the screen is too small.
Set app:backgroundTint = "@null" fixes the auto color change made by the app in the dark mode.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then:
Here are the testing on my own cell phone, even the second smallest text is too large for the screen so the buttons are wrapped in two rows. Only the smallest text can fit.
|Screenshot 1| Screenshot 2|
|--|--|
|||
LTR
| Before | After |
|:------:|:-----:|
| | |
|||