-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4737: No meaningful label of the revision screen navigation cards during talkback. #5113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Akshatkamboj14! This is a very clean solution, great job.
I have left a couple of comments, please address them fully and send this back for review.
Unassigning @adhiamboperes since the review is done. |
Hi @Akshatkamboj14, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
app/src/sharedTest/java/org/oppia/android/app/topic/revisioncard/RevisionCardFragmentTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/topic/revisioncard/RevisionCardFragmentTest.kt
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/topic/revisioncard/RevisionCardFragmentTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Akshatkamboj14! This LGTM.
…n-navigation-cards-during-talkback
Unassigning @adhiamboperes since they have already approved the PR. |
Hi @Akshatkamboj14, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes #4737
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then:
talkback.webm