Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5086 : Implement Dark Mode support for NPS Survey #5104

Merged
merged 12 commits into from
Aug 1, 2023

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    dd32a17 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b31b18f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d7da9e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    400eab5 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    bf455b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Fix Part of #5086: Add Layout Land for Survey UI (#5110)

    ## Explanation
    Fix Part of #5086: We found that the navigation buttons in some
    questions were not displaying correctly in landscape mode on phones.
    This issue affects the survey popup as well. See
    #5104 (comment).
    
    This PR introduces dedicated landscape layouts for the affected screens.
    
    There are some minor bug fixes/ ux improvements also added that are
    related to the survey behaviour:
    1. Make the exit confirmation dialog non-cancelable so that the user
    makes use of the dialog buttons.
    2.Prevent accidentally exiting the survey by showing the exit
    confirmation dialog on backpress.
    3. Resume normal flow on exiting an exploration, when the survey is not
    to be shown.
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [ ] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [ ] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    
    ### Before 
    
    ![image](https://github.com/oppia/oppia-android/assets/59600948/46b76a8e-82f3-4dd3-9f95-d83268ccf9a5)
    
    ### After
    ![Screenshot 2023-07-28 at 00 25
    19](https://github.com/oppia/oppia-android/assets/59600948/c9518e0b-d610-4532-91ce-d23b80e4dd1a)
    
    ### Before+Light Mode, After+Dark Mode
    ![Screenshot 2023-07-28 at 01 32
    02](https://github.com/oppia/oppia-android/assets/59600948/89fbbdb5-7905-4afb-abb4-6bfd041466ae)
    
    ### Before+Light Mode, After+Dark Mode
    ![Screenshot 2023-07-28 at 01 40
    50](https://github.com/oppia/oppia-android/assets/59600948/88ba0852-a95d-4b86-bc2f-2682da5908b0)
    adhiamboperes authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    8be1622 View commit details
    Browse the repository at this point in the history
  2. fix designer changes

    MohitGupta121 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a7197d7 View commit details
    Browse the repository at this point in the history
  3. restore minor changes

    MohitGupta121 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f813c8e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    868fcdc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d92c8c9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9320ddb View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    2b7919e View commit details
    Browse the repository at this point in the history