-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5086 : Implement Dark Mode support for NPS Survey #5104
Merged
Commits on Jul 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dd32a17 - Browse repository at this point
Copy the full SHA dd32a17View commit details -
Configuration menu - View commit details
-
Copy full SHA for b31b18f - Browse repository at this point
Copy the full SHA b31b18fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7da9e8 - Browse repository at this point
Copy the full SHA d7da9e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 400eab5 - Browse repository at this point
Copy the full SHA 400eab5View commit details
Commits on Jul 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bf455b0 - Browse repository at this point
Copy the full SHA bf455b0View commit details
Commits on Jul 31, 2023
-
Fix Part of #5086: Add Layout Land for Survey UI (#5110)
## Explanation Fix Part of #5086: We found that the navigation buttons in some questions were not displaying correctly in landscape mode on phones. This issue affects the survey popup as well. See #5104 (comment). This PR introduces dedicated landscape layouts for the affected screens. There are some minor bug fixes/ ux improvements also added that are related to the survey behaviour: 1. Make the exit confirmation dialog non-cancelable so that the user makes use of the dialog buttons. 2.Prevent accidentally exiting the survey by showing the exit confirmation dialog on backpress. 3. Resume normal flow on exiting an exploration, when the survey is not to be shown. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [ ] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [ ] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only ### Before ![image](https://github.com/oppia/oppia-android/assets/59600948/46b76a8e-82f3-4dd3-9f95-d83268ccf9a5) ### After ![Screenshot 2023-07-28 at 00 25 19](https://github.com/oppia/oppia-android/assets/59600948/c9518e0b-d610-4532-91ce-d23b80e4dd1a) ### Before+Light Mode, After+Dark Mode ![Screenshot 2023-07-28 at 01 32 02](https://github.com/oppia/oppia-android/assets/59600948/89fbbdb5-7905-4afb-abb4-6bfd041466ae) ### Before+Light Mode, After+Dark Mode ![Screenshot 2023-07-28 at 01 40 50](https://github.com/oppia/oppia-android/assets/59600948/88ba0852-a95d-4b86-bc2f-2682da5908b0)
Configuration menu - View commit details
-
Copy full SHA for 8be1622 - Browse repository at this point
Copy the full SHA 8be1622View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7197d7 - Browse repository at this point
Copy the full SHA a7197d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f813c8e - Browse repository at this point
Copy the full SHA f813c8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 868fcdc - Browse repository at this point
Copy the full SHA 868fcdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d92c8c9 - Browse repository at this point
Copy the full SHA d92c8c9View commit details -
Merge remote-tracking branch 'upstream/nps_survey_dark_mode' into nps…
…_survey_dark_mode
Configuration menu - View commit details
-
Copy full SHA for 9320ddb - Browse repository at this point
Copy the full SHA 9320ddbView commit details
Commits on Aug 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2b7919e - Browse repository at this point
Copy the full SHA 2b7919eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.