Skip to content

Commit

Permalink
Fix CI runs on develop.
Browse files Browse the repository at this point in the history
This can't be easily verified until it's merged, however I have high
confidence that this should fix it as we've done similar fallback syntax
for env variables in the past (e.g. '||') and 'origin/develop' was the
value previously used for the base commit when computing affected tests.
  • Loading branch information
BenHenning committed May 22, 2024
1 parent 24b1721 commit f1e6fe2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ jobs:
id: compute-test-matrix
env:
compute_all_targets: ${{ contains(github.event.pull_request.title, '[RunAllTests]') }}
# See: https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request.
base_commit_hash: ${{ github.event.pull_request.base.sha }}
# See: https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request. Defer to origin/develop outside a PR (such as develop's main CI runs).
base_commit_hash: ${{ github.event.pull_request.base.sha || "origin/develop" }}
# https://unix.stackexchange.com/a/338124 for reference on creating a JSON-friendly
# comma-separated list of test targets for the matrix.
run: |
Expand Down

0 comments on commit f1e6fe2

Please sign in to comment.