Skip to content

Commit

Permalink
remove unwanted condition from dark-mode wiki
Browse files Browse the repository at this point in the history
  • Loading branch information
MohitGupta121 committed Aug 5, 2023
1 parent d55b7e6 commit cf2f254
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion wiki/Dark-Mode.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,5 +112,4 @@ These rules were followed while implementing dark-mode designs in android app:
- Ensure that the naming of new colors across all files should follow the rules mentioned [above](https://github.com/oppia/oppia-android/wiki/Dark-Mode#knowing-the-convention).
- If any new color is getting introduced in the `color_defs.xml` file, then treat it as a red flag and keep a close eye on why it is getting introduced? Why can't any of the existing colors be used? Has this been approved by the design team?
- If any new color palette is getting introduced in `color_palette.xml` keep a close eye on that to make sure that there is no similar color palette already defined in `color_palette.xml` light/dark files. If there is a similar color palette, can you rename the existing color_palette such that it can be used on existing places as well as new places?
- Other than thumbnails and icons in `mipmap` and `drawable` folder, all other places should reference color code from `component_colors.xml` file only. There should not be any direct usage of color from `color_palette.xml` or `color_defs.xml` or any other file. (Note: there is an issue filed at [#5114](https://github.com/oppia/oppia-android/issues/5114) to do this automatically via a CI check, but until that issue is resolved, this needs to be checked manually.)
- Hardcoded-colors should only be mentioned in icons/thumbnails of `mipmap` and `drawable`folder and in the `color_defs.xml` file.

0 comments on commit cf2f254

Please sign in to comment.