Remove redundant test in test_file_exemptions.textproto

More cleanup for eventloggingconfigurationmodule
oppia · Oct 29, 2024 · c800a57 · c800a57
1 parent 74eded5
commit c800a57
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/...c/sharedTest/java/org/oppia/android/app/databinding/TextInputLayoutBindingAdaptersTest.kt b/...c/sharedTest/java/org/oppia/android/app/databinding/TextInputLayoutBindingAdaptersTest.kt
@@ -76,7 +76,6 @@ import org.oppia.android.util.caching.AssetModule
 import org.oppia.android.util.caching.testing.CachingTestModule
 import org.oppia.android.util.gcsresource.GcsResourceModule
 import org.oppia.android.util.locale.LocaleProdModule
-import org.oppia.android.util.logging.EventLoggingConfigurationModule
 import org.oppia.android.util.logging.LoggerModule
 import org.oppia.android.util.logging.SyncStatusModule
 import org.oppia.android.util.logging.firebase.FirebaseLogUploaderModule
@@ -167,12 +166,12 @@ class TextInputLayoutBindingAdaptersTest {
 
   private fun launchActivity():
     ActivityScenario<TextInputLayoutBindingAdaptersTestActivity>? {
-      val scenario = ActivityScenario.launch<TextInputLayoutBindingAdaptersTestActivity>(
-        TextInputLayoutBindingAdaptersTestActivity.createIntent(context)
-      )
-      testCoroutineDispatchers.runCurrent()
-      return scenario
-    }
+    val scenario = ActivityScenario.launch<TextInputLayoutBindingAdaptersTestActivity>(
+      TextInputLayoutBindingAdaptersTestActivity.createIntent(context)
+    )
+    testCoroutineDispatchers.runCurrent()
+    return scenario
+  }
 
   private fun setUpTestApplicationComponent() {
     ApplicationProvider.getApplicationContext<TestApplication>().inject(this)
@@ -205,7 +204,7 @@ class TextInputLayoutBindingAdaptersTest {
       MathEquationInputModule::class, SplitScreenInteractionModule::class,
       LoggingIdentifierModule::class, ApplicationLifecycleModule::class,
       SyncStatusModule::class, MetricLogSchedulerModule::class, TestingBuildFlavorModule::class,
-      EventLoggingConfigurationModule::class, ActivityRouterModule::class,
+      ActivityRouterModule::class,
       CpuPerformanceSnapshotterModule::class, ExplorationProgressModule::class,
       TestAuthenticationModule::class
     ]

diff --git a/scripts/assets/test_file_exemptions.textproto b/scripts/assets/test_file_exemptions.textproto
@@ -4354,10 +4354,6 @@ test_file_exemption {
   exempted_file_path: "utility/src/main/java/org/oppia/android/util/logging/ConsoleLoggerInjectorProvider.kt"
   test_file_not_required: true
 }
-test_file_exemption {
-  exempted_file_path: "utility/src/main/java/org/oppia/android/util/logging/EventTypeToHumanReadableNameConverter.kt"
-  test_file_not_required: true
-}
 test_file_exemption {
   exempted_file_path: "utility/src/main/java/org/oppia/android/util/logging/ExceptionLogger.kt"
   test_file_not_required: true

diff --git a/utility/src/main/java/org/oppia/android/util/logging/BUILD.bazel b/utility/src/main/java/org/oppia/android/util/logging/BUILD.bazel
@@ -110,6 +110,17 @@ kt_android_library(
     visibility = ["//:oppia_api_visibility"],
 )
 
+kt_android_library(
+    name = "event_type_to_human_readable_name_converter",
+    srcs = [
+        "EventTypeToHumanReadableNameConverter.kt",
+    ],
+    deps = [
+        "//model/src/main/proto:event_logger_java_proto_lite",
+        "//third_party:javax_inject_javax_inject",
+    ],
+)
+
 kt_android_library(
     name = "prod_module",
     srcs = [