-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #17219 Corrected the Fraction output logic #10
base: master
Are you sure you want to change the base?
Conversation
@seanlip PTAL! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HardikGoyal2003 Which code am I actually supposed to review here? I don't see the source file(s) from which all these builds were generated, and I also don't understand why this has changed so much from the master branch. Could you please explain?
@seanlip I analysed and what I found is:
Thanks! |
This reverts commit a7409fd.
@seanlip PTAL! I have reverted the last commit and now test command has not been run but build command has been run and min.js has been edited manually. Thanks |
@HardikGoyal2003 This is a concern IMO. We need a standard build process that also updates the min.js file, and this should be documented in the PR template etc. What should that process be? What does the guppy project itself usually use? ("Manual changes" isn't an acceptable answer.) |
Overview
Essential Checklist
Proof that changes are correct
Screencast.from.02-03-24.12.21.14.AM.IST.webm
PR Pointers