mDNS Repeater plugin: Enable blocklist parameter in the gui to allow blocking subnets. #4362
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kodehyrden
changed the title
Monviech
reviewed
Nov 21, 2024
net/mdns-repeater/src/opnsense/mvc/app/controllers/OPNsense/MDNSRepeater/forms/general.xml
Outdated
Show resolved
Hide resolved
net/mdns-repeater/src/opnsense/mvc/app/models/OPNsense/MDNSRepeater/MDNSRepeater.xml
Outdated
Show resolved
Hide resolved
net/mdns-repeater/src/opnsense/service/templates/OPNsense/MDNSRepeater/mdnsrepeater
Outdated
Show resolved
Hide resolved
net/mdns-repeater/src/opnsense/mvc/app/models/OPNsense/MDNSRepeater/MDNSRepeater.xml
Outdated
Show resolved
Hide resolved
|
https://github.com/geekman/mdns-repeater/releases/tag/1.11 It says here that it supports 16 addresses in a blocklist. Why is it limited to 1 in the PR? |
Monviech
reviewed
Nov 21, 2024
| <Default></Default> | ||
| <Required>N</Required> | ||
| </interfaces> | ||
| <ValidationMessage>Add entire subnets in CIDR notation, e.g. 192.168.1.0/24. Only one IPv4 subnet is allowed. <ValidationMessage> | ||
| <Mask>^((25[0-5]|2[0-4]\d|1\d\d|[1-9]?\d)\.){3}(25[0-5]|2[0-4]\d|1\d\d|[1-9]?\d)\/([0-9]|[12][0-9]|3[0-2])$<Mask> |
There was a problem hiding this comment.
Why are you using regex here. The network field has validation for IP addresses, is it not enough?
Monviech
reviewed
Nov 22, 2024
There was a problem hiding this comment.
I want to know why you aren't using the code examples I gave you earlier.
It would allow for multiple networks in the same input field, with the tokenizer separating them cleanly, and commas being automatically added.
Right now I think you expect the user to input their own comma separated list?
Please improve on this concept.
| <Default></Default> | ||
| <Required>N</Required> | ||
| <ValidationMessage>Please enter one or more valid IPv4 networks or individual addresses in CIDR notation.<ValidationMessage> | ||
| <NetMaskRequired>Y<NetMaskRequired> |
There was a problem hiding this comment.
Are you testing what you implement here? The xml is wrong. A few / are missing.
Please test what you do.
root@opn-ce-01:/src/git/opnsense_plugins/net/mdns-repeater # make lint
/src/git/opnsense_plugins/net/mdns-repeater/src/opnsense/mvc/app/models/OPNsense/MDNSRepeater/MDNSRepeater.xml:27: parser error : Opening and ending tag mismatch: AsList line 26 and blocklist
</blocklist>
^
/src/git/opnsense_plugins/net/mdns-repeater/src/opnsense/mvc/app/models/OPNsense/MDNSRepeater/MDNSRepeater.xml:28: parser error : Opening and ending tag mismatch: AsList line 26 and items
</items>
^
/src/git/opnsense_plugins/net/mdns-repeater/src/opnsense/mvc/app/models/OPNsense/MDNSRepeater/MDNSRepeater.xml:29: parser error : Opening and ending tag mismatch: AddressFamily line 25 and model
</model>
^
/src/git/opnsense_plugins/net/mdns-repeater/src/opnsense/mvc/app/models/OPNsense/MDNSRepeater/MDNSRepeater.xml:30: parser error : Premature end of data in tag AddressFamily line 25
^
*** Error code 1
Stop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should mitigate the problem described in this forum post:
https://forum.opnsense.org/index.php?topic=44083.0
It will allow the user to add a subnet to be blocked by the mDNS Repeater. The parameter is already available in the program itself.
This is my very first commit to this repository. Comments are very much welcome. FYI I have also mailed Franz Fabian, maintainer of the mDNS Repeater plugin for OPNsense.