-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kea: Add direct reservation from leases page #8073
base: master
Are you sure you want to change the base?
Conversation
This adds the ability to configure the DHCP socket type (UDP/Raw) in the Kea DHCP server settings through the web UI. - Added socket type field to model definition - Added dropdown in general settings form - Updated config generation to include socket type setting
…e/kea-socket-type
This commit adds functionality to create DHCP reservations directly from the leases page. Users can now convert existing leases to reservations with a single click. - Added addReservationAction to handle reservation creation - Updated leases view with reservation button - Added Apply button for service reconfiguration - Added proper validation and subnet matching
please give me your honest feedback - i would appreciate your improvements!!! |
I have to think about this, the feature overlaps with an earlier PR (#8039), one of the main concerns I see is that it's generally not a good idea to assign addresses inside an existing pool as these are free for usage when the machine in question is not connected (at least with Ones we started to accept these in the legacy (isc-dhcp) server, we have had several reports about this behavior, which isn't ours to fix. |
i could have checked other PRs before spending time on this. You maybe got another issue for me that i could support (something easy)? honestly the other PR (#8039) is better in terms of how he handled the add reservation |
no problem, things happen.
Any particular topic in mind you would like to spend time on? There likely aren't a lot of easy ones, but I can search the list to see if something might be worth giving a try. |
This PR adds the ability to create DHCP reservations directly from the leases page in Kea DHCP.
Ref: #8035
While this PR doesn't implement the full wizard functionality requested in the issue, it provides a first step towards that goal by allowing users to:
The current implementation automatically matches the subnet based on the IP address and transfers the existing hostname. This could be extended in the future to include a full wizard with more configuration options as suggested in the original issue.
Current features:
This provides a foundation that could be expanded to include the full wizard functionality in the future.
Changes: