Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kea: Add direct reservation from leases page #8073

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pieewiee
Copy link
Contributor

This PR adds the ability to create DHCP reservations directly from the leases page in Kea DHCP.

Ref: #8035

While this PR doesn't implement the full wizard functionality requested in the issue, it provides a first step towards that goal by allowing users to:

  • Convert an existing lease to a reservation with a single click
  • See which leases are already reserved
  • Apply changes through an integrated Apply button

The current implementation automatically matches the subnet based on the IP address and transfers the existing hostname. This could be extended in the future to include a full wizard with more configuration options as suggested in the original issue.

Current features:

  • Added addReservationAction to Leases4Controller
  • Updated leases view with reservation button and Apply functionality
  • Added proper validation and subnet matching for new reservations
  • Visual indication of which leases are already reserved

This provides a foundation that could be expanded to include the full wizard functionality in the future.

Changes:

  • Added addReservationAction to handle reservation creation
  • Updated leases view with reservation button
  • Added Apply button for service reconfiguration
  • Added proper validation and subnet matching

lease

reserved

This adds the ability to configure the DHCP socket type (UDP/Raw) in the
Kea DHCP server settings through the web UI.

- Added socket type field to model definition
- Added dropdown in general settings form
- Updated config generation to include socket type setting
This commit adds functionality to create DHCP reservations directly from the leases page.
Users can now convert existing leases to reservations with a single click.

- Added addReservationAction to handle reservation creation
- Updated leases view with reservation button
- Added Apply button for service reconfiguration
- Added proper validation and subnet matching
@pieewiee
Copy link
Contributor Author

pieewiee commented Nov 19, 2024

please give me your honest feedback - i would appreciate your improvements!!!

@AdSchellevis
Copy link
Member

I have to think about this, the feature overlaps with an earlier PR (#8039), one of the main concerns I see is that it's generally not a good idea to assign addresses inside an existing pool as these are free for usage when the machine in question is not connected (at least with isc-dhcp).

Ones we started to accept these in the legacy (isc-dhcp) server, we have had several reports about this behavior, which isn't ours to fix.

@pieewiee
Copy link
Contributor Author

i could have checked other PRs before spending time on this. You maybe got another issue for me that i could support (something easy)?

honestly the other PR (#8039) is better in terms of how he handled the add reservation

@AdSchellevis
Copy link
Member

i could have checked other PRs before spending time on this.

no problem, things happen.

You maybe got another issue for me that i could support (something easy)?

Any particular topic in mind you would like to spend time on? There likely aren't a lot of easy ones, but I can search the list to see if something might be worth giving a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants