Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide initial ListNVMfRemoteNamespaces implementation. #465

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

artek-koltun
Copy link
Contributor

@artek-koltun artek-koltun commented Jun 15, 2023

see #12

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear why we need it
Also I think Ben wanted to create and delete those namespaces in a forloop when spdk attaching and detaching from nvme bdev controller

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #465 (6bc1b58) into main (17e5134) will decrease coverage by 1.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
- Coverage   65.16%   64.14%   -1.03%     
==========================================
  Files          21       22       +1     
  Lines        3207     3258      +51     
==========================================
  Hits         2090     2090              
- Misses        989     1040      +51     
  Partials      128      128              
Impacted Files Coverage Δ
pkg/backend/nvme_namespace.go 0.00% <0.00%> (ø)

@artek-koltun
Copy link
Contributor Author

Sorry, missed the comment.
My understanding is that ListNVMfRemoteNamespaces is needed for a client to get all discovered namespaces after a remote controller is connected, so we could assign them to middleend/frontend. It is also why we can only list them, but not create/delete.
@benlwalker could you please clarify?

@glimchb
Copy link
Member

glimchb commented Jun 28, 2023

Sorry, missed the comment. My understanding is that ListNVMfRemoteNamespaces is needed for a client to get all discovered namespaces after a remote controller is connected, so we could assign them to middleend/frontend. It is also why we can only list them, but not create/delete. @benlwalker could you please clarify?

what I mean is we already call bdev_get_bdevs in several places... not sure I understand why we need yet another one... maybe if we show how to create those first, then list will make more sense... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants