Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtio-blk QoS limits #415

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

artek-koltun
Copy link
Contributor

Since virtio-blk can have only one volume attached, virtio-blk is the only device type which can demonstrate QoS on device level.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #415 (751137e) into main (f8ecca3) will increase coverage by 0.02%.
The diff coverage is 79.59%.

@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   79.60%   79.63%   +0.02%     
==========================================
  Files          18       18              
  Lines        2584     2627      +43     
==========================================
+ Hits         2057     2092      +35     
- Misses        491      498       +7     
- Partials       36       37       +1     
Impacted Files Coverage Δ
pkg/frontend/frontend.go 61.29% <36.36%> (-8.28%) ⬇️
pkg/frontend/blk.go 94.50% <92.10%> (-0.74%) ⬇️

@artek-koltun artek-koltun marked this pull request as ready for review June 2, 2023 12:09
@artek-koltun artek-koltun requested a review from a team as a code owner June 2, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant