feat: adding evpn use case files to opi-intel-bridge #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dimitrios Markou <[email protected]> Co-authored-by: Saikumar Banoth <[email protected]> Co-authored-by: Patel Atul <[email protected]> Co-authored-by: Vemula Venkatesh <[email protected]> Co-authored-by: Jambekar Vishakha <[email protected]> Signed-off-by: atulpatel261194 <[email protected]>
atulpatel261194
force-pushed
the
evpnUseCase
branch
2 times, most recently
from
b341d20 to
5a711ad
Compare
Co-authored-by: Dimitrios Markou <[email protected]> Co-authored-by: Saikumar Banoth <[email protected]> Co-authored-by: Patel Atul <[email protected]> Co-authored-by: Vemula Venkatesh <[email protected]> Co-authored-by: Jambekar Vishakha <[email protected]> Signed-off-by: atulpatel261194 <[email protected]>
atulpatel261194
force-pushed
the
evpnUseCase
branch
from
5a711ad to
b253b86
Compare
atulpatel261194
force-pushed
the
evpnUseCase
branch
2 times, most recently
from
962a871 to
1ccdeb2
Compare
artek-koltun
reviewed
Sep 3, 2024
cmd/evpn/main.go
Outdated
| frr.Initialize() | ||
| ipu_vendor.Initialize() | ||
|
|
||
| case "ci": |
There was a problem hiding this comment.
why do you need ci here if it is a vendor xpu?
cmd/evpn/main.go
Outdated
|
|
||
| // initialize cobra config | ||
| if err := initialize(); err != nil { | ||
| // log.Println(err) |
There was a problem hiding this comment.
please cleanup of commented code
Signed-off-by: atulpatel261194 <[email protected]>
atulpatel261194
force-pushed
the
evpnUseCase
branch
from
1ccdeb2 to
c460b12
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: atulpatel261194 <[email protected]>
artek-koltun
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation for transition from opi-evpn-bridge to opi-intel-bridge
This PR includes the following changes: