Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evpn_bridge): Feature ECMP #403

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

atulpatel261194
Copy link
Contributor

No description provided.

Signed-off-by: atulpatel261194 <[email protected]>
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 138 lines in your changes missing coverage. Please review.

Project coverage is 20.11%. Comparing base (5440fb9) to head (4bd9510).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
pkg/netlink/nexthop.go 0.00% 92 Missing ⚠️
pkg/netlink/netlink_watcher.go 0.00% 20 Missing ⚠️
pkg/netlink/route.go 0.00% 17 Missing ⚠️
pkg/netlink/common.go 0.00% 6 Missing ⚠️
pkg/frr/frr.go 0.00% 2 Missing ⚠️
pkg/netlink/neighbor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #403       +/-   ##
===========================================
- Coverage   50.77%   20.11%   -30.66%     
===========================================
  Files          37       51       +14     
  Lines        2525     6905     +4380     
===========================================
+ Hits         1282     1389      +107     
- Misses       1114     5348     +4234     
- Partials      129      168       +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atulpatel261194 atulpatel261194 marked this pull request as ready for review October 14, 2024 15:40
@atulpatel261194 atulpatel261194 requested a review from a team as a code owner October 14, 2024 15:40
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes all look reasonable

@sandersms sandersms merged commit bd3c72b into opiproject:main Oct 14, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants