Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split evpn folder #270

Merged
merged 2 commits into from
Oct 19, 2023
Merged

refactor: split evpn folder #270

merged 2 commits into from
Oct 19, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Oct 19, 2023

Working on #268

This PR still keeeps everything in the same package
Will split packages as well next

Signed-off-by: Boris Glimcher [email protected]

@glimchb glimchb marked this pull request as ready for review October 19, 2023 14:23
@glimchb glimchb requested a review from a team as a code owner October 19, 2023 14:23
@glimchb glimchb marked this pull request as draft October 19, 2023 14:24
Fixes opiproject#268

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #270 (667e0a7) into main (cdb8b5e) will increase coverage by 2.83%.
The diff coverage is 79.57%.

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   58.34%   61.18%   +2.83%     
==========================================
  Files          20       27       +7     
  Lines        1575     1837     +262     
==========================================
+ Hits          919     1124     +205     
- Misses        570      609      +39     
- Partials       86      104      +18     
Files Coverage Δ
pkg/bridge/bridge.go 56.12% <ø> (ø)
pkg/bridge/bridge_netlink.go 100.00% <ø> (ø)
pkg/bridge/bridge_validate.go 74.28% <ø> (ø)
pkg/port/port.go 65.38% <ø> (ø)
pkg/port/port_validate.go 75.00% <ø> (ø)
pkg/svi/svi.go 48.44% <ø> (ø)
pkg/svi/svi_frr.go 17.64% <ø> (ø)
pkg/svi/svi_netlink.go 100.00% <ø> (ø)
pkg/svi/svi_validate.go 75.67% <ø> (ø)
pkg/vrf/vrf.go 54.76% <ø> (ø)
... and 11 more

@glimchb glimchb marked this pull request as ready for review October 19, 2023 19:56
@glimchb glimchb linked an issue Oct 19, 2023 that may be closed by this pull request
@glimchb glimchb merged commit 3ad107b into opiproject:main Oct 19, 2023
18 checks passed
@glimchb glimchb deleted the models branch October 19, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

it's time to split pkg/evpn to multiple packages
1 participant