Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(frr): start using mockery #255

Merged
merged 1 commit into from
Oct 16, 2023
Merged

test(frr): start using mockery #255

merged 1 commit into from
Oct 16, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Oct 16, 2023

Fixes #251

Signed-off-by: Boris Glimcher [email protected]

@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #255 (8d834ba) into main (9dafc65) will decrease coverage by 0.64%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   64.87%   64.23%   -0.64%     
==========================================
  Files          16       16              
  Lines        1318     1317       -1     
==========================================
- Hits          855      846       -9     
- Misses        426      427       +1     
- Partials       37       44       +7     
Files Coverage Δ
pkg/utils/frr.go 0.00% <ø> (ø)
pkg/evpn/evpn.go 84.61% <71.42%> (-0.64%) ⬇️
pkg/evpn/svi.go 74.53% <0.00%> (-1.16%) ⬇️
pkg/evpn/vrf.go 78.41% <0.00%> (-2.81%) ⬇️

... and 2 files with indirect coverage changes

@glimchb glimchb marked this pull request as ready for review October 16, 2023 22:08
@glimchb glimchb requested a review from a team as a code owner October 16, 2023 22:08
@glimchb glimchb merged commit 15b7489 into opiproject:main Oct 16, 2023
16 of 18 checks passed
@glimchb glimchb deleted the vtysh branch October 16, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frr: check err code
1 participant