ci: replace static comamnds with grpc calls #103

glimchb · 2023-08-09T19:11:22Z

used https://www.browserling.com/tools/ip-to-dec to convert IP string to number
used python -c "import base64; print(base64.b64encode('\xaa\xbb\xcc\x00\x00\x42'))" for MAC translation

Signed-off-by: Boris Glimcher [email protected]

codecov · 2023-08-09T19:12:38Z

Codecov Report

Merging #103 (4ff5865) into main (652a65a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   48.00%   48.00%           
=======================================
  Files           5        5           
  Lines         852      852           
=======================================
  Hits          409      409           
  Misses        424      424           
  Partials       19       19

docker-compose.yml

Signed-off-by: Boris Glimcher <[email protected]>

per code review Signed-off-by: Boris Glimcher <[email protected]>

docker-compose.yml

venkatmahalingam · 2023-08-30T04:02:56Z

docker-compose.yml

+      /entrypoint.sh call --json_input --json_output localhost:50151 CreateLogicalBridge  "{\"logical_bridge_id\" : \"vlan30\",        \"logical_bridge\" :  {\"spec\" : {\"vni\" : 30, \"vlan_id\": 30 }} }" && \
+      /entrypoint.sh call --json_input --json_output localhost:50151 CreateLogicalBridge  "{\"logical_bridge_id\" : \"vlan40\",        \"logical_bridge\" :  {\"spec\" : {\"vni\" : 40, \"vlan_id\": 40 }} }" && \
+      /entrypoint.sh call --json_input --json_output localhost:50151 CreateLogicalBridge  "{\"logical_bridge_id\" : \"vlan50\",        \"logical_bridge\" :  {\"spec\" : {              \"vlan_id\": 50 }} }" && \
+      /entrypoint.sh call --json_input --json_output localhost:50151 CreateSvi            "{\"svi_id\"            : \"blue-vlan20\",   \"svi\" :             {\"spec\" : {\"vrf\": \"//network.opiproject.org/vrfs/blue\",   \"logical_bridge\": \"//network.opiproject.org/bridges/vlan20\", \"mac_address\" : \"qrvMAAAh\", \"gw_ip_prefix\": [{\"addr\": {\"af\": \"IP_AF_INET\", \"v4_addr\": 336860161}, \"len\": 24}] }} }" && \


Can we use vlan20 instead of blue-vlan20 for SVI name? and logical_bridge_id as br"vlan-id"? ,e.g br50

I specifically want the SVI name to reflect the binding between VRF and logical bridge.
And I don't see any reason to encode the object type as prefix into the logical bridge objects. We are not doing that for other object types either. How we call the underlying Linux realization entities is a different matter.

How we call the underlying Linux realization entities is a different matter.
-> This is the problem, unnecessary lengthy names lead to have additional mapping in the backend as Linux interface names length restricted to 15 characters. IMO, it is easy to get and know the SVI to VRF mappings, if we want to rebind the SVI from one VRF to another VRF on the fly, I would need to delete the SVI and create it with new VRF name part of SVI name.

I agree with @venkatmahalingam on this problem

if we want to rebind the SVI from one VRF to another VRF on the fly, I would need to delete the SVI and create it with new VRF name part of SVI name.

But naming of objects is left to the user, there is no code or rules to mandate to use any names... so we as OPI should not care...
user will pick a name or (since resource ID) is optional, grpc server will generate UUID as a name (or more accurately resource ID) instead...

How realistic and important a use case is it to move a subnet on a logical bridge to another VRF without any traffic impact? To me that is a change in network planning, which typically has wider implications in the network.
I know it is possible in Linux to shift an existing SVI netdev to another VRF just by enslaving it to the new vrf netdev, but is this something the EVPN-GW API must cover? In fact, I think it currently does cover it, as the VRF reference in the SVI spec is not marked as immutable. Same goes for the LogicalBridge reference, by the way, but the VLAN ID of an SVI netdev can't be changed in Linux on the fly.
At any rate, the object naming arbitrary, and we can apply any convention we like in this example configuration.

venkatmahalingam · 2023-08-30T04:09:10Z

docker-compose.yml

-            ip link add vni40 type vxlan id 40 local 10.0.0.2 dstport 4789 nolearning && \
-            ip link set vni40 master br-tenant up && \
-            bridge vlan add dev vni40 vid 40 pvid untagged && \
-            bridge link set dev vni40 neigh_suppress on learning off && \


How the fields "neigh_suppress" and "learning off" are mapped to the API?

They don't have to be reflected in the API. They are hard-coded in the EVPN-bridge implementation (until the point where someone shows that it is necessary to be able to control them. Then we can discuss how to enhance the logical bridge API with an optional attribute).

venkatmahalingam · 2023-08-30T04:19:25Z

docker-compose.yml

+      /entrypoint.sh call --json_input --json_output localhost:50151 CreateVrf            "{\"vrf_id\"            : \"blue\",          \"vrf\" :             {\"spec\" : {               \"loopback_ip_prefix\": {\"addr\": {\"af\": \"IP_AF_INET\", \"v4_addr\": 167772418}, \"len\": 24}, \"vtep_ip_prefix\": {\"addr\": {\"af\": \"IP_AF_INET\", \"v4_addr\": 167772162}, \"len\": 24} }} }" && \
+      /entrypoint.sh call --json_input --json_output localhost:50151 CreateVrf            "{\"vrf_id\"            : \"green\",         \"vrf\" :             {\"spec\" : {\"vni\" : 100, \"loopback_ip_prefix\": {\"addr\": {\"af\": \"IP_AF_INET\", \"v4_addr\": 167772674}, \"len\": 24}, \"vtep_ip_prefix\": {\"addr\": {\"af\": \"IP_AF_INET\", \"v4_addr\": 167772162}, \"len\": 24} }} }" && \
+      /entrypoint.sh call --json_input --json_output localhost:50151 CreateVrf            "{\"vrf_id\"            : \"yellow\",        \"vrf\" :             {\"spec\" : {\"vni\" : 101, \"loopback_ip_prefix\": {\"addr\": {\"af\": \"IP_AF_INET\", \"v4_addr\": 167772930}, \"len\": 24}, \"vtep_ip_prefix\": {\"addr\": {\"af\": \"IP_AF_INET\", \"v4_addr\": 167772162}, \"len\": 24} }} }" && \
+      /entrypoint.sh call --json_input --json_output localhost:50151 CreateLogicalBridge  "{\"logical_bridge_id\" : \"vlan10\",        \"logical_bridge\" :  {\"spec\" : {\"vni\" : 10, \"vlan_id\": 10 }} }" && \


ip link add vni10 type vxlan id 10 local 10.0.0.2 dstport 4789 nolearning

How's the above command is mapped in the API incase of L2VXLAN (I dont expect VRF and SVI objects in L2-VXLAN)? where to provide VTEP local IP in the API?

The VRF spec has a field vtep_ip_prefix for this purpose.

Why do we need a VRF for L2VXLAN case?

Good catch, the LogicalBridgeSpec in the API should also have a vtep_ip_prefix. See issue #83

opened #147 for VTEP IP

JanScheurich

LGTM

glimchb force-pushed the main branch 4 times, most recently from 2d18bd4 to 8555203 Compare August 9, 2023 20:34

glimchb commented Aug 9, 2023

View reviewed changes

docker-compose.yml Show resolved Hide resolved

glimchb commented Aug 9, 2023

View reviewed changes

docker-compose.yml Outdated Show resolved Hide resolved

glimchb commented Aug 9, 2023

View reviewed changes

docker-compose.yml Outdated Show resolved Hide resolved

glimchb force-pushed the main branch 8 times, most recently from 5444bb0 to f555b63 Compare August 11, 2023 17:18

glimchb force-pushed the main branch 2 times, most recently from f38c8d2 to 78b0fa9 Compare August 26, 2023 02:56

glimchb marked this pull request as ready for review August 26, 2023 03:00

glimchb requested a review from a team as a code owner August 26, 2023 03:00

glimchb force-pushed the main branch from 78b0fa9 to 89b744c Compare August 26, 2023 03:11

glimchb requested a review from a team August 26, 2023 03:12

glimchb force-pushed the main branch 2 times, most recently from 0ae4f7f to 1ca25c4 Compare August 28, 2023 20:48

JanScheurich suggested changes Aug 29, 2023

View reviewed changes

docker-compose.yml Show resolved Hide resolved

docker-compose.yml Outdated Show resolved Hide resolved

docker-compose.yml Outdated Show resolved Hide resolved

glimchb requested review from a team and venkatmahalingam August 29, 2023 13:37

glimchb force-pushed the main branch from 1ca25c4 to 1ca76e1 Compare August 30, 2023 01:38

glimchb added 2 commits August 30, 2023 06:28

ci: move static config from leaf1 to testgrpc

2273cbb

Signed-off-by: Boris Glimcher <[email protected]>

ci(vrf): replace static comamnds with grpc calls

edf7192

Signed-off-by: Boris Glimcher <[email protected]>

glimchb added 5 commits August 30, 2023 06:28

ci(bridge): replace static comamnds with grpc calls

631dab7

Signed-off-by: Boris Glimcher <[email protected]>

ci(svi): replace static comamnds with grpc calls

6ac6aa3

Signed-off-by: Boris Glimcher <[email protected]>

ci(port): replace static comamnds with grpc calls

45a14bb

Signed-off-by: Boris Glimcher <[email protected]>

fix(review): use correct VRF loop IPs

3c33b1d

Signed-off-by: Boris Glimcher <[email protected]>

ci(svi): prefix svi_id with vrf name

ca3d9a0

Signed-off-by: Boris Glimcher <[email protected]>

glimchb force-pushed the main branch from 1ca76e1 to ca3d9a0 Compare August 30, 2023 03:28

ci(bridge): rename logical_bridge_id from vniXX to vlanXX

4ff5865

per code review Signed-off-by: Boris Glimcher <[email protected]>

glimchb added the Merge Candidate in the open merge window, next candidate for merge label Aug 30, 2023

venkatmahalingam reviewed Aug 30, 2023

View reviewed changes

docker-compose.yml Show resolved Hide resolved

venkatmahalingam reviewed Aug 30, 2023

View reviewed changes

JanScheurich approved these changes Aug 31, 2023

View reviewed changes

glimchb merged commit 1a2b0e5 into opiproject:main Aug 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: replace static comamnds with grpc calls #103

ci: replace static comamnds with grpc calls #103

glimchb commented Aug 9, 2023 •

edited

Loading

codecov bot commented Aug 9, 2023 •

edited

Loading

venkatmahalingam Aug 30, 2023 •

edited

Loading

JanScheurich Aug 30, 2023

venkatmahalingam Aug 30, 2023 •

edited

Loading

glimchb Aug 31, 2023

JanScheurich Sep 1, 2023

venkatmahalingam Aug 30, 2023

JanScheurich Aug 30, 2023

venkatmahalingam Aug 30, 2023 •

edited

Loading

JanScheurich Aug 30, 2023

venkatmahalingam Aug 30, 2023

JanScheurich Aug 31, 2023

glimchb Aug 31, 2023 •

edited

Loading

JanScheurich left a comment

ci: replace static comamnds with grpc calls #103

ci: replace static comamnds with grpc calls #103

Conversation

glimchb commented Aug 9, 2023 • edited Loading

codecov bot commented Aug 9, 2023 • edited Loading

Codecov Report

venkatmahalingam Aug 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

venkatmahalingam Aug 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

venkatmahalingam Aug 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glimchb Aug 31, 2023 • edited Loading

Choose a reason for hiding this comment

JanScheurich left a comment

Choose a reason for hiding this comment

glimchb commented Aug 9, 2023 •

edited

Loading

codecov bot commented Aug 9, 2023 •

edited

Loading

venkatmahalingam Aug 30, 2023 •

edited

Loading

venkatmahalingam Aug 30, 2023 •

edited

Loading

venkatmahalingam Aug 30, 2023 •

edited

Loading

glimchb Aug 31, 2023 •

edited

Loading