[Op#57902]: Refactor shared logic for Multi-project activation #16765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabiru
changed the title
akabiru
force-pushed
the
code-maintenance/57902-dry-up-shared-logic-for-multi-project-activation
branch
from
d8d4bb3
to
4f94f66
Compare
DRY up common logic in: - `CustomFields::CustomFieldProjects::BulkCreateService` - `ProjectCustomFieldProjectMappings::BulkCreateService` - `::Storages::ProjectStorages::BulkCreateService`
Co-authored-by: Cristophe Bliard <[email protected]>
Not sur about this one, but tests pass.
Actually, I think the params parameter should be on the set attributes service call.
We want to filter out id, created_at, updated_at because they would be nil. Compacting the hash is enough to remove them.
As we use it later to broadcast project storages created, it feels odd to give it to the projects mapper and then read it from it later. It feels more natural to keep it inside the service. It decouples the logic a little bit more.
Let's see if it's better.
akabiru
force-pushed
the
code-maintenance/57902-dry-up-shared-logic-for-multi-project-activation
branch
from
bc6b304
to
3e3f2e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/57902
What are you trying to accomplish?
CustomFields::CustomFieldProjects::BulkCreateServiceProjectCustomFieldProjectMappings::BulkCreateService::Storages::ProjectStorages::BulkCreateService