[#56779] Allow empty lines in rich text #16620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: All code changes are in opf/commonmark-ckeditor-build#96
Ticket
https://community.openproject.org/work_packages/56779
What are you trying to accomplish?
Allow empty lines everywhere in our rich text (markdown with html)
Screenshots
What approach did you choose and why?
Support blank lines on markdown root level
Markdown does not support multiple blank lines. So I adapted the format supported by most markdown parsers/renderers.
(
First line\n\n<br>\n\n<br>\n\nFourth line
)compatible with:
Support blank lines in table cells
We store tables as HTML, so we just need to preserve empty lines as paragraphs
<p><br></p>
compatible with:
Support blank lines in lists
As for empty lines on root level, blank lines in lists are not supported by markdown, therefor we use the same method.
compatible with:
Support blank lines in code blocks
Empty markdown code blocks are inflated to have at least one empty line
compatible with:
Merge checklist