Skip to content

Commit

Permalink
Disable turbo on old new pages
Browse files Browse the repository at this point in the history
  • Loading branch information
oliverguenther committed Nov 10, 2024
1 parent 754d796 commit 3cea2f3
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 9 deletions.
1 change: 1 addition & 0 deletions modules/meeting/app/views/meetings/new.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ See COPYRIGHT and LICENSE files for more details.
:id => 'meeting-form',
target: '_top',
:data => {
turbo: false,
controller: 'refresh-on-form-changes',
'refresh-on-form-changes-target': 'form',
'refresh-on-form-changes-turbo-stream-url-value': new_meeting_url
Expand Down
13 changes: 5 additions & 8 deletions modules/meeting/spec/features/meetings_new_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
end
end

context "without a project set", skip: "TEMP" do
context "without a project set" do
before do
new_page.visit!
new_page.set_title "Some title"
Expand Down Expand Up @@ -181,7 +181,7 @@
show_page.expect_invited(admin)
end

context "without a project set", skip: "TEMP" do
context "without a project set" do
before do
new_page.visit!
new_page.set_title "Some title"
Expand All @@ -190,15 +190,12 @@
it "renders a validation error" do
new_page.click_create

expect_flash(
message: "#{Project.model_name.human} #{I18n.t('activerecord.errors.messages.blank')}",
type: :error
)
expect(page).to have_text "#{Project.model_name.human} #{I18n.t('activerecord.errors.messages.blank')}"
new_page.expect_project_dropdown
end
end

context "without a title set", skip: "TEMP" do
context "without a title set" do
before do
new_page.visit!

Expand Down Expand Up @@ -259,7 +256,7 @@
end
end

context "without a title set", skip: "TEMP" do
context "without a title set" do
before do
new_page.visit!
new_page.set_start_date "2013-03-28"
Expand Down
6 changes: 5 additions & 1 deletion modules/meeting/spec/support/pages/meetings/new.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ def set_project(project)
end

def set_start_date(date)
fill_in "Start date", with: date, fill_options: { clear: :backspace }
if using_cuprite?
fill_in "Start date", with: date
else
fill_in "Start date", with: date, fill_options: { clear: :backspace }
end
end

def set_start_time(time)
Expand Down

0 comments on commit 3cea2f3

Please sign in to comment.