cleanup

src/commonmark/commonmark.js

@@ -6,7 +6,6 @@
 import CommonMarkDataProcessor from './commonmarkdataprocessor';
 
 // Simple plugin which loads the data processor.
-// eslint-disable-next-line no-unused-vars
 export default function CommonMarkPlugin(editor) {
  editor.data.processor = new CommonMarkDataProcessor(editor.editing.view.document);
 }

src/commonmark/commonmarkdataprocessor.js

@@ -106,23 +106,25 @@ export default class CommonMarkDataProcessor {
  // Turndown is filtering out empty paragraphs <p></p>, so we need to fix that with <p><br></p>
  breaksPreprocessor(domFragment);
 
+ const blankReplacement = function (content, node) {
+ if (node.tagName === 'CODE') {
+ // we don't want to remove code silently
+ const prefix = (node.getAttribute('class') || '').replace('language-', '');
+ const textContent = node.textContent || '';
+
+ return "```" + prefix + '\n' + (textContent.length ? textContent : '\n') + "```\n";
+ // we don't want to remove pre silently
+ } else if (node.tagName === 'PRE') {
+ return content;
+ }
+ return node.isBlock ? '\n\n' : ''
+ };
+
  // Use Turndown to convert DOM fragment to markdown
  const turndownService = new TurndownService({
  headingStyle: 'atx',
  codeBlockStyle: 'fenced',
- blankReplacement: function (content, node) {
- if (node.tagName === 'CODE') {
- // we don't want to remove code silently
- const prefix = (node.getAttribute('class') || '').replace('language-', '');
- const textContent = node.textContent || '';
-
- return "```" + prefix + '\n' + (textContent.length ? textContent : '\n') + "```\n";
- // we don't want to remove pre silently
- } else if (node.tagName === 'PRE') {
- return content;
- }
- return node.isBlock ? '\n\n' : ''
- },
+ blankReplacement: blankReplacement,
  });
 
  turndownService.use([
@@ -170,7 +172,7 @@ export default class CommonMarkDataProcessor {
  // figure and the image in the imageFigure rule
  turndownService.addRule('figcaption', {
  filter: 'figcaption',
- replacement: function (content, node) {
+ replacement: function (_content, _node) {
  return '';
  }
  });

src/commonmark/utils/preprocessor.js

@@ -38,7 +38,7 @@ export function textNodesPreprocessor(root, allowed_whitespace_nodes, allowed_ra
  * @param {*} allowed_whitespace_nodes
  * @param {*} allowed_raw_nodes
  */
-export function linkPreprocessor(root, allowed_whitespace_nodes, allowed_raw_nodes) {
+export function linkPreprocessor(root, _allowed_whitespace_nodes, _allowed_raw_nodes) {
  let walker = document.createNodeIterator(
  root,
  // Only consider element nodes
@@ -57,7 +57,7 @@ export function linkPreprocessor(root, allowed_whitespace_nodes, allowed_raw_nod
  }
 }
 
-export function breaksPreprocessor(root, allowed_whitespace_nodes, allowed_raw_nodes) {
+export function breaksPreprocessor(root, _allowed_whitespace_nodes, _allowed_raw_nodes) {
  let walker = document.createNodeIterator(
  root,
  NodeFilter.SHOW_ELEMENT,

tests/commonmark/lists.test.js

@@ -4,10 +4,6 @@
  */
 
 import {testDataProcessor} from './_utils/utils.js';
-import MarkdownDataProcessor from '../../src/commonmark/commonmarkdataprocessor';
-import HtmlDataProcessor from '@ckeditor/ckeditor5-engine/src/dataprocessor/htmldataprocessor.js';
-import ViewDocument from '@ckeditor/ckeditor5-engine/src/view/document.js';
-import {StylesProcessor} from '@ckeditor/ckeditor5-engine/src/view/stylesmap.js';
 
 describe('CommonMarkProcessor', () => {
  describe('lists', () => {