🌱 bump k8s, helm-operator-plugins, of/operator-registry, and of/api

.bingo/Variables.mk

@@ -1,4 +1,4 @@
-# Auto generated binary variables helper managed by https://github.com/bwplotka/bingo v0.8. DO NOT EDIT.
+# Auto generated binary variables helper managed by https://github.com/bwplotka/bingo v0.9. DO NOT EDIT.
 # All tools are designed to be build inside $GOBIN.
 BINGO_DIR := $(dir $(lastword $(MAKEFILE_LIST)))
 GOPATH ?= $(shell go env GOPATH)
@@ -29,11 +29,11 @@ $(CONTROLLER_GEN): $(BINGO_DIR)/controller-gen.mod
  @echo "(re)installing $(GOBIN)/controller-gen-v0.12.0"
  @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=controller-gen.mod -o=$(GOBIN)/controller-gen-v0.12.0 "sigs.k8s.io/controller-tools/cmd/controller-gen"
 
-GINKGO := $(GOBIN)/ginkgo-v2.13.0
+GINKGO := $(GOBIN)/ginkgo-v2.14.0
 $(GINKGO): $(BINGO_DIR)/ginkgo.mod
  @# Install binary/ries using Go 1.14+ build command. This is using bwplotka/bingo-controlled, separate go module with pinned dependencies.
- @echo "(re)installing $(GOBIN)/ginkgo-v2.13.0"
- @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=ginkgo.mod -o=$(GOBIN)/ginkgo-v2.13.0 "github.com/onsi/ginkgo/v2/ginkgo"
+ @echo "(re)installing $(GOBIN)/ginkgo-v2.14.0"
+ @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=ginkgo.mod -o=$(GOBIN)/ginkgo-v2.14.0 "github.com/onsi/ginkgo/v2/ginkgo"
 
 GOLANGCI_LINT := $(GOBIN)/golangci-lint-v1.53.2
 $(GOLANGCI_LINT): $(BINGO_DIR)/golangci-lint.mod

.bingo/ginkgo.mod

@@ -2,4 +2,4 @@ module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT
 
 go 1.20
 
-require github.com/onsi/ginkgo/v2 v2.13.0 // ginkgo
+require github.com/onsi/ginkgo/v2 v2.14.0 // ginkgo

.bingo/ginkgo.sum

@@ -16,6 +16,10 @@ github.com/onsi/ginkgo/v2 v2.12.0 h1:UIVDowFPwpg6yMUpPjGkYvf06K3RAiJXUhCxEwQVHRI
 github.com/onsi/ginkgo/v2 v2.12.0/go.mod h1:ZNEzXISYlqpb8S36iN71ifqLi3vVD1rVJGvWRCJOUpQ=
 github.com/onsi/ginkgo/v2 v2.13.0 h1:0jY9lJquiL8fcf3M4LAXN5aMlS/b2BV86HFFPCPMgE4=
 github.com/onsi/ginkgo/v2 v2.13.0/go.mod h1:TE309ZR8s5FsKKpuB1YAQYBzCaAfUgatB/xlT/ETL/o=
+github.com/onsi/ginkgo/v2 v2.13.2 h1:Bi2gGVkfn6gQcjNjZJVO8Gf0FHzMPf2phUei9tejVMs=
+github.com/onsi/ginkgo/v2 v2.13.2/go.mod h1:XStQ8QcGwLyF4HdfcZB8SFOS/MWCgDuXMSBe6zrvLgM=
+github.com/onsi/ginkgo/v2 v2.14.0 h1:vSmGj2Z5YPb9JwCWT6z6ihcUvDhuXLc3sJiqd3jMKAY=
+github.com/onsi/ginkgo/v2 v2.14.0/go.mod h1:JkUdW7JkN0V6rFvsHcJ478egV3XH9NxpD27Hal/PhZw=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5cxcmMvtA=
@@ -25,6 +29,10 @@ golang.org/x/tools v0.6.0 h1:BOw41kyTf3PuCW1pVQf8+Cyg8pMlkYB1oo9iJ6D/lKM=
 golang.org/x/tools v0.6.0/go.mod h1:Xwgl3UAJ/d3gWutnCtw505GrjyAbvKui8lOU390QaIU=
 golang.org/x/tools v0.12.0 h1:YW6HUoUmYBpwSgyaGaZq1fHjrBjX1rlpZ54T6mu2kss=
 golang.org/x/tools v0.12.0/go.mod h1:Sc0INKfu04TlqNoRA1hgpFZbhYXHPr4V5DzpSBTPqQM=
+golang.org/x/tools v0.14.0 h1:jvNa2pY0M4r62jkRQ6RwEZZyPcymeL9XZMLBbV7U2nc=
+golang.org/x/tools v0.14.0/go.mod h1:uYBEerGOWcJyEORxN+Ek8+TT266gXkNlHdJBwexUsBg=
+golang.org/x/tools v0.16.1 h1:TLyB3WofjdOEepBHAU20JdNC1Zbg87elYofWYAY5oZA=
+golang.org/x/tools v0.16.1/go.mod h1:kYVVN6I1mBNoB1OX+noeBjbRk4IUEPa7JJ+TJMEooJ0=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

.bingo/variables.env

@@ -1,4 +1,4 @@
-# Auto generated binary variables helper managed by https://github.com/bwplotka/bingo v0.8. DO NOT EDIT.
+# Auto generated binary variables helper managed by https://github.com/bwplotka/bingo v0.9. DO NOT EDIT.
 # All tools are designed to be build inside $GOBIN.
 # Those variables will work only until 'bingo get' was invoked, or if tools were installed via Makefile's Variables.mk.
 GOBIN=${GOBIN:=$(go env GOBIN)}
@@ -12,7 +12,7 @@ BINGO="${GOBIN}/bingo-v0.8.0"
 
 CONTROLLER_GEN="${GOBIN}/controller-gen-v0.12.0"
 
-GINKGO="${GOBIN}/ginkgo-v2.13.0"
+GINKGO="${GOBIN}/ginkgo-v2.14.0"
 
 GOLANGCI_LINT="${GOBIN}/golangci-lint-v1.53.2"
 

cmd/core/main.go

@@ -37,10 +37,11 @@ import (
  "k8s.io/kube-aggregator/pkg/apis/apiregistration"
  ctrl "sigs.k8s.io/controller-runtime"
  "sigs.k8s.io/controller-runtime/pkg/cache"
- "sigs.k8s.io/controller-runtime/pkg/cluster"
+ "sigs.k8s.io/controller-runtime/pkg/client"
  crfinalizer "sigs.k8s.io/controller-runtime/pkg/finalizer"
  "sigs.k8s.io/controller-runtime/pkg/healthz"
  "sigs.k8s.io/controller-runtime/pkg/log/zap"
+ "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 
  rukpakv1alpha2 "github.com/operator-framework/rukpak/api/v1alpha2"
  "github.com/operator-framework/rukpak/internal/controllers/bundledeployment"
@@ -119,51 +120,47 @@ func main() {
  systemNamespace = util.PodNamespace()
  }
 
- systemNsCluster, err := cluster.New(cfg, func(opts *cluster.Options) {
- opts.Scheme = scheme
- opts.Namespace = systemNamespace
- })
+ storageURL, err := url.Parse(fmt.Sprintf("%s/bundles/", httpExternalAddr))
  if err != nil {
- setupLog.Error(err, "unable to create system namespace cluster")
+ setupLog.Error(err, "unable to parse bundle content server URL")
  os.Exit(1)
  }
+
+ localStorage := &storage.LocalDirectory{
+ RootDirectory: provisionerStorageDirectory,
+ URL: *storageURL,
+ }
+
  mgr, err := ctrl.NewManager(cfg, ctrl.Options{
- Scheme: scheme,
- MetricsBindAddress: httpBindAddr,
- Port: 9443,
- HealthProbeBindAddress: probeAddr,
- LeaderElection: enableLeaderElection,
- LeaderElectionID: "core.rukpak.io",
- NewCache: cache.BuilderWithOptions(cache.Options{
- SelectorsByObject: cache.SelectorsByObject{
+ Scheme: scheme,
+ Cache: cache.Options{
+ ByObject: map[client.Object]cache.ByObject{
  &rukpakv1alpha2.BundleDeployment{}: {},
  },
- DefaultSelector: cache.ObjectSelector{
- Label: dependentSelector,
+ DefaultNamespaces: map[string]cache.Config{
+ systemNamespace: {},
+ cache.AllNamespaces: {LabelSelector: dependentSelector},
+ },
+ },
+ Metrics: server.Options{
+ BindAddress: httpBindAddr,
+ ExtraHandlers: map[string]http.Handler{
+ // NOTE: ExtraHandlers aren't actually metrics-specific. We can run
+ // whatever handlers we want on the existing webserver that
+ // controller-runtime runs when MetricsBindAddress is configured on the
+ // manager.
+ "/bundles/": httpLogger(localStorage),
  },
- }),
+ },
+ HealthProbeBindAddress: probeAddr,
+ LeaderElection: enableLeaderElection,
+ LeaderElectionID: "core.rukpak.io",
  })
  if err != nil {
  setupLog.Error(err, "unable to create manager")
  os.Exit(1)
  }
 
- if err := mgr.Add(systemNsCluster); err != nil {
- setupLog.Error(err, "unable to add system namespace cluster to manager")
- os.Exit(1)
- }
-
- storageURL, err := url.Parse(fmt.Sprintf("%s/bundles/", httpExternalAddr))
- if err != nil {
- setupLog.Error(err, "unable to parse bundle content server URL")
- os.Exit(1)
- }
-
- localStorage := &storage.LocalDirectory{
- RootDirectory: provisionerStorageDirectory,
- URL: *storageURL,
- }
-
  var rootCAs *x509.CertPool
  if bundleCAFile != "" {
  var err error
@@ -179,15 +176,6 @@ func main() {
  )
  bundleStorage := storage.WithFallbackLoader(localStorage, httpLoader)
 
- // NOTE: AddMetricsExtraHandler isn't actually metrics-specific. We can run
- // whatever handlers we want on the existing webserver that
- // controller-runtime runs when MetricsBindAddress is configured on the
- // manager.
- if err := mgr.AddMetricsExtraHandler("/bundles/", httpLogger(localStorage)); err != nil {
- setupLog.Error(err, "unable to add bundles http handler to manager")
- os.Exit(1)
- }
-
  // This finalizer logic MUST be co-located with this main
  // controller logic because it deals with cleaning up bundle data
  // from the bundle cache when the bundles are deleted. The
@@ -207,14 +195,22 @@ func main() {
  os.Exit(1)
  }
 
- unpacker, err := source.NewDefaultUnpacker(systemNsCluster, systemNamespace, unpackImage, rootCAs)
+ unpacker, err := source.NewDefaultUnpacker(mgr, systemNamespace, unpackImage, rootCAs)
  if err != nil {
  setupLog.Error(err, "unable to setup bundle unpacker")
  os.Exit(1)
  }
 
- cfgGetter := helmclient.NewActionConfigGetter(mgr.GetConfig(), mgr.GetRESTMapper(), mgr.GetLogger())
- acg := helmclient.NewActionClientGetter(cfgGetter)
+ cfgGetter, err := helmclient.NewActionConfigGetter(mgr.GetConfig(), mgr.GetRESTMapper(), mgr.GetLogger())
+ if err != nil {
+ setupLog.Error(err, "unable to create action config getter")
+ os.Exit(1)
+ }
+ acg, err := helmclient.NewActionClientGetter(cfgGetter)
+ if err != nil {
+ setupLog.Error(err, "unable to create action client getter")
+ os.Exit(1)
+ }
  commonBDProvisionerOptions := []bundledeployment.Option{
  bundledeployment.WithReleaseNamespace(systemNamespace),
  bundledeployment.WithActionClientGetter(acg),
@@ -223,7 +219,7 @@ func main() {
  bundledeployment.WithUnpacker(unpacker),
  }
 
- if err := bundledeployment.SetupWithManager(mgr, systemNsCluster.GetCache(), systemNamespace, append(
+ if err := bundledeployment.SetupWithManager(mgr, systemNamespace, append(
  commonBDProvisionerOptions,
  bundledeployment.WithProvisionerID(plain.ProvisionerID),
  bundledeployment.WithHandler(bundledeployment.HandlerFunc(plain.HandleBundleDeployment)),
@@ -232,7 +228,7 @@ func main() {
  os.Exit(1)
  }
 
- if err := bundledeployment.SetupWithManager(mgr, systemNsCluster.GetCache(), systemNamespace, append(
+ if err := bundledeployment.SetupWithManager(mgr, systemNamespace, append(
  commonBDProvisionerOptions,
  bundledeployment.WithProvisionerID(registry.ProvisionerID),
  bundledeployment.WithHandler(bundledeployment.HandlerFunc(registry.HandleBundleDeployment)),

cmd/crdvalidator/handlers/crd.go

@@ -42,8 +42,9 @@ type CrdValidator struct {
 
 func NewCrdValidator(log logr.Logger, client client.Client) CrdValidator {
  return CrdValidator{
- log: log.V(1).WithName("crdhandler"), // Default to non-verbose logs
- client: client,
+ log: log.V(1).WithName("crdhandler"), // Default to non-verbose logs
+ client: client,
+ decoder: admission.NewDecoder(client.Scheme()),
  }
 }
 
@@ -74,12 +75,6 @@ func (cv *CrdValidator) Handle(ctx context.Context, req admission.Request) admis
  return admission.Allowed("")
 }
 
-// InjectDecoder injects a decoder for the CrdValidator.
-func (cv *CrdValidator) InjectDecoder(d *admission.Decoder) error {
- cv.decoder = d
- return nil
-}
-
 // disabled takes a CRD and checks its content to see crdvalidator
 // is disabled explicitly
 func disabled(crd *apiextensionsv1.CustomResourceDefinition) bool {

cmd/crdvalidator/main.go

@@ -23,8 +23,10 @@ import (
 
  apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  "k8s.io/apimachinery/pkg/runtime"
+ ctrl "sigs.k8s.io/controller-runtime"
  "sigs.k8s.io/controller-runtime/pkg/client/config"
  "sigs.k8s.io/controller-runtime/pkg/log"
+ "sigs.k8s.io/controller-runtime/pkg/log/zap"
  "sigs.k8s.io/controller-runtime/pkg/manager"
  "sigs.k8s.io/controller-runtime/pkg/manager/signals"
  "sigs.k8s.io/controller-runtime/pkg/webhook"
@@ -48,9 +50,16 @@ func init() {
 
 func main() {
  var enableHTTP2 bool
-
  flag.BoolVar(&enableHTTP2, "enable-http2", enableHTTP2, "If HTTP/2 should be enabled for the webhook servers.")
 
+ opts := zap.Options{
+ Development: true,
+ }
+ opts.BindFlags(flag.CommandLine)
+
+ flag.Parse()
+ ctrl.SetLogger(zap.New(zap.UseFlagOptions(&opts)))
+
  // Setup webhook options
  disableHTTP2 := func(c *tls.Config) {
  if enableHTTP2 {
@@ -59,9 +68,10 @@ func main() {
  c.NextProtos = []string{"http/1.1"}
  }
 
- webhookServer := &webhook.Server{
+ webhookServer := webhook.NewServer(webhook.Options{
  TLSOpts: []func(config *tls.Config){disableHTTP2},
- }
+ CertDir: defaultCertDir,
+ })
 
  entryLog.Info("setting up manager")
  mgr, err := manager.New(config.GetConfigOrDie(), manager.Options{Scheme: scheme, WebhookServer: webhookServer})
@@ -73,9 +83,6 @@ func main() {
  entryLog.Info("setting up webhook server")
  hookServer := mgr.GetWebhookServer()
 
- // Point to where cert-mgr is placing the cert
- hookServer.CertDir = defaultCertDir
-
  // Register CRD validation handler
  entryLog.Info("registering webhooks to the webhook server")
  crdValidatorHandler := handlers.NewCrdValidator(entryLog, mgr.GetClient())