Remove Bundle API and its controller #774

varshaprasad96 · 2023-12-18T18:41:29Z

As discussed here this PR intends to remove the Bundle API for purposes of having a single interface to handle bundle unpacking, templating and installation.

The following are the changes made:

TODO in follow ups:

Fix documentation.
Clean up all the comments in the code base that reference bundle API instead of bundle deployments.

internal/controllers/bundledeployment/interfaces.go

codecov · 2023-12-18T18:44:06Z

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (ea72d31) 20.62% compared to head (9a7827b) 26.32%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
...l/controllers/bundledeployment/bundledeployment.go	0.00%	104 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
+ Coverage   20.62%   26.32%   +5.70%     
==========================================
  Files          14        9       -5     
  Lines        1086      809     -277     
==========================================
- Hits          224      213      -11     
+ Misses        812      550     -262     
+ Partials       50       46       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/storage/http_test.go

internal/util/util.go

cmd/core/main.go

cmd/rukpakctl/cmd/run.go

go.mod

internal/controllers/bundledeployment/bundledeployment.go

internal/controllers/bundledeployment/interfaces.go

internal/rukpakctl/run.go

internal/storage/http.go

internal/util/adopt.go

internal/util/util.go

manifests/base/apis/crds/patches/bundledeployment_validation.yaml

internal/controllers/bundledeployment/bundledeployment.go

unpacking. Signed-off-by: Varsha Prasad Narsing <[email protected]>

Signed-off-by: Varsha Prasad Narsing <[email protected]>

This commit introduces a new condition to indicate whether the bundle has been uploaded successfully by the uploadmgr. Once the upload is successful, the reconciler further starts unpacking the contents. Signed-off-by: Varsha Prasad Narsing <[email protected]>

The commit does the following: 1. Fix bundleDeployment names to be camelcase. 2. Remove rukpakctl, upload source and relevant upload mgr code. 3. Remove the requirement for requeing. 4. Remove the use of a separate "Processor" interface for handling unpacked contents before installing. 5. Fix DOckerfile and Goreleaser to not handle rukpakctl binary. Signed-off-by: Varsha Prasad Narsing <[email protected]>

varshaprasad96 requested a review from a team as a code owner December 18, 2023 18:41

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2023

varshaprasad96 commented Dec 18, 2023

View reviewed changes

internal/controllers/bundledeployment/interfaces.go Outdated Show resolved Hide resolved

varshaprasad96 force-pushed the remove/bundle-api branch 5 times, most recently from 143f0c2 to fa65678 Compare December 21, 2023 18:41

varshaprasad96 changed the title ~~wip: remove bundle controller~~ Remove Bundle API and its controller Dec 21, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2023

varshaprasad96 force-pushed the remove/bundle-api branch from fa65678 to 1e3fd2c Compare December 21, 2023 18:54

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2024

ncdc reviewed Jan 8, 2024

View reviewed changes

internal/storage/http_test.go Outdated Show resolved Hide resolved

internal/util/util.go Show resolved Hide resolved

internal/util/util.go Show resolved Hide resolved

internal/util/util.go Outdated Show resolved Hide resolved

varshaprasad96 force-pushed the remove/bundle-api branch 2 times, most recently from 4398792 to ca3e38f Compare January 10, 2024 17:22

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2024

varshaprasad96 force-pushed the remove/bundle-api branch from ca3e38f to 4f54625 Compare January 10, 2024 22:16