Fix error message being lost when upgrading #6815
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where an error message was being discarded. Occurs when upgrading a bundle. Signed-off-by: Sebastian Soto <[email protected]>
|
@saifshaikh48: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -451,7 +451,7 @@ func (c IndexImageCatalogCreator) UpdateCatalog(ctx context.Context, cs *v1alpha | |||
| // check if index image adopts File-Based Catalog or SQLite index image format | |||
| isFBCImage, err := fbcutil.IsFBC(ctx, c.IndexImage) | |||
| if err != nil { | |||
| return fmt.Errorf("error in upgrading the bundle %q that was installed traditionally", c.BundleImage) | |||
| return fmt.Errorf("unable to determine if index image adopts File-Based Catalog or SQLite format: %v", err) | |||
There was a problem hiding this comment.
consider including the index image in the error message.
e.g.
fmt.Errorf("unable to determine if index image %q adopts File-Based Catalog or SQLite format: %v", c.IndexImage, err)
There was a problem hiding this comment.
if so, also update here
operator-sdk/internal/olm/operator/registry/index_image.go
Lines 429 to 433 in d2366be
mateusoliveira43
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Fixes an issue where an error message was being discarded. Occurs when upgrading a bundle.
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs