Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kube update #2989

Merged
merged 8 commits into from
Jul 14, 2023
Merged

Kube update #2989

merged 8 commits into from
Jul 14, 2023

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jul 11, 2023

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tmshort
Copy link
Contributor Author

tmshort commented Jul 11, 2023

/test all

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

@tmshort: No presubmit jobs available for operator-framework/operator-lifecycle-manager@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmshort tmshort mentioned this pull request Jul 12, 2023
Closed
11 tasks
@tmshort tmshort force-pushed the kube-update branch 2 times, most recently from fe2b2d0 to fd467a7 Compare July 13, 2023 20:19
@tmshort tmshort marked this pull request as ready for review July 13, 2023 20:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2023
@perdasilva
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2023
tmshort and others added 8 commits July 14, 2023 09:33
@tmshort
Update dependencies
5266e2b 
Update k8s to v0.27.2
Update controller-runtime to v0.15.0
Update code to support new APIs

Signed-off-by: Todd Short <[email protected]>
@tmshort
Update to operator-registry v1.27.1
3dfc0fa 
Signed-off-by: Todd Short <[email protected]>
@tmshort
Run make verify
de5bf14 
Signed-off-by: Todd Short <[email protected]>
@tmshort
Update kind to v0.20.0
1020f63 
Signed-off-by: Todd Short <[email protected]>
@tmshort
Update to go 1.20
563cde8 
Signed-off-by: Todd Short <[email protected]>
@tmshort
Update packagemanifest
1ba1a46 
Signed-off-by: Todd Short <[email protected]>
@tmshort
Update golangci-lint to 1.51.1
d2f38cc 
Signed-off-by: Todd Short <[email protected]>
@tmshort
Address golangci-lint comments
676e893 
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Todd Short <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2023
@kevinrizza
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2023
@tmshort tmshort merged commit 6b377ca into operator-framework:master Jul 14, 2023
15 checks passed
@tmshort tmshort deleted the kube-update branch July 14, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@awgreene awgreene Awaiting requested review from awgreene

Assignees

@perdasilva perdasilva

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmshort @perdasilva @kevinrizza