Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] ⚠️ Bump ClusterExtension API to v1 #1228

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Sep 6, 2024

Description

  • Updates ClusterExtension to v1
  • Adds operatorsv1alpha1 package alias for operators/v1alpha1
  • Does NOT update to catalogd v1 (as that's not merged or released yet)

Closes #1155

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner September 6, 2024 15:14
@perdasilva perdasilva changed the title ⚠️ Bump CatalogExtension API to v1 [HOLD] ⚠️ Bump CatalogExtension API to v1 Sep 6, 2024
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 88f4d40
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6704dc0ae657ea000991cfb2
😎 Deploy Preview https://deploy-preview-1228--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.42%. Comparing base (5097435) to head (88f4d40).

Files with missing lines Patch % Lines
internal/contentmanager/sourcerer.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1228   +/-   ##
=======================================
  Coverage   76.42%   76.42%           
=======================================
  Files          41       41           
  Lines        2431     2431           
=======================================
  Hits         1858     1858           
  Misses        400      400           
  Partials      173      173           
Flag Coverage Δ
e2e 58.45% <80.00%> (ø)
unit 53.68% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva
Copy link
Contributor Author

@yashoza19 I just saw that you had your name down on the ticket to bump the API. I was on a bit of rampage today and didn't notice and went ahead and did it. I'm sorry about that. If it's helpful, please take what I've done here, otherwise, I'm happy to close. Apologies again =(

@yashoza19
Copy link
Contributor

@yashoza19 I just saw that you had your name down on the ticket to bump the API. I was on a bit of rampage today and didn't notice and went ahead and did it. I'm sorry about that. If it's helpful, please take what I've done here, otherwise, I'm happy to close. Apologies again =(

@perdasilva No worries at all. I was holding this issue off until we are done with all the other issues in epic-v1.

@LalatenduMohanty
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2024
@perdasilva perdasilva marked this pull request as draft September 12, 2024 13:39
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch 2 times, most recently from 374f2ce to ccf704f Compare September 25, 2024 15:34
@perdasilva perdasilva changed the title [HOLD] ⚠️ Bump CatalogExtension API to v1 [HOLD] ⚠️ Bump ClusterExtension API to v1 Sep 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
Signed-off-by: Per Goncalves da Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote v1alpha1 ClusterExtension API version to v1
4 participants