-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain why subscriptions do not adopt CSVs #252
Explain why subscriptions do not adopt CSVs #252
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick drive by review.
9fde96d
to
b1c08d9
Compare
Just one more comment but this lgtm. /lgtm |
- The `Subscription` requires an `CSV` that fulfills it. | ||
- The existing `CSV` must appear in the solution set (remember, it cannot fulfill the requirements of `Subscriptions` it is not associated with). | ||
|
||
This ultimately returns a failure message similar to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect readers to see this and assume that any similar-looking error prefix will have the same underlying cause. This document's purpose isn't to explain the way constraints are modeled inside the catalog operator, but it would benefit from a little exposition about the constraints within the message.
b1c08d9
to
37eee1e
Compare
New changes are detected. LGTM label has been removed. |
@@ -29,6 +29,35 @@ If the `Status` block does not provide enough information, check the [Catalog op | |||
|
|||
`Subscriptions` cannot install operators provided by `CatalogSources` that are not in the same namespace unless the `CatalogSource` is created in the `olm` namespace. | |||
|
|||
### A subscription fails because I deleted a similar subscription and left the CSV it installed | |||
|
|||
By creating a `Subscription`, the user is "subscribing" to updates from a particular package and channel within a `CatalogSource`. When a `ClusterServiceVersion (CSV)` is created to fulfill the `Subscription`, the `Subscription` is updated so it is "associated" with that `CSV`. "Associated" `CSVs` do not need to appear in the solution set allowing the `Subscription's` requirements to be met by `CSVs` in the channel that are valid upgrades from the existing `CSV`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: "Subscription's
" -> "Subscription
's"
37eee1e
to
32fbaa3
Compare
Update the subscription.md document to explain why a Subscription cannot adopt existing ClusterServiceVersions that are not associated with it. Signed-off-by: Alexander Greene <[email protected]> Signed-off-by: Per Goncalves da Silva <[email protected]>
32fbaa3
to
326e816
Compare
Update the subscription.md document to explain why a Subscription cannot adopt existing ClusterServiceVersions that are not associated with it.
Signed-off-by: Alexander Greene [email protected]