Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 main.go: improve logging for configuration of global auth #417

Merged

Conversation

joelanford
Copy link
Member

No description provided.

@joelanford joelanford requested a review from a team as a code owner September 26, 2024 20:08
@joelanford joelanford changed the title main.go: improve logging for configuration of global auth 🐛 main.go: improve logging for configuration of global auth Sep 26, 2024
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.56%. Comparing base (a34f172) to head (d231774).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/manager/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   35.65%   35.56%   -0.09%     
==========================================
  Files          14       14              
  Lines         805      807       +2     
==========================================
  Hits          287      287              
- Misses        472      474       +2     
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford added this pull request to the merge queue Sep 26, 2024
Merged via the queue into operator-framework:main with commit a0037dd Sep 26, 2024
11 of 13 checks passed
@joelanford joelanford deleted the auth-file-path-logging branch September 26, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants