Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Use default creds if present for pulling catalog images #416

Merged
merged 1 commit into from
Sep 26, 2024
Merged

✨ Use default creds if present for pulling catalog images #416

merged 1 commit into from
Sep 26, 2024

Conversation

anik120
Copy link
Collaborator

@anik120 anik120 commented Sep 26, 2024

No description provided.

@anik120 anik120 requested a review from a team as a code owner September 26, 2024 10:46
@anik120 anik120 marked this pull request as draft September 26, 2024 10:46
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 35.65%. Comparing base (e57db1f) to head (8cd2cf1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/manager/main.go 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   36.05%   35.65%   -0.41%     
==========================================
  Files          14       14              
  Lines         796      805       +9     
==========================================
  Hits          287      287              
- Misses        463      472       +9     
  Partials       46       46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anik120 added a commit to anik120/operator-framework-catalogd that referenced this pull request Sep 26, 2024
@anik120
OPRUN-3558: Add hostPath mount for /var/lib/kubelet
41a61a3 
MCO makes the global pull secrets available in `/var/lib/kubelet`.
Catalogd will look for these secrets in `/etc/catalogd`
folder, ref [catalogd:416](operator-framework/catalogd#416).

This PR hostPath mounts the `/var/lib/kublet` directory from the host to the
`/etc/catalogd` directory in the container's filesystem.

RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing)
Signed-off-by: Anik Bhattacharjee <[email protected]>
@anik120 anik120 mentioned this pull request Sep 26, 2024
Merged
@anik120 anik120 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
@anik120 anik120 marked this pull request as ready for review September 26, 2024 15:08
@anik120
Copy link
Collaborator Author

anik120 commented Sep 26, 2024

RFC has been approved.

@anik120 anik120 self-assigned this Sep 26, 2024
@joelanford joelanford added this pull request to the merge queue Sep 26, 2024
Merged via the queue into operator-framework:main with commit a34f172 Sep 26, 2024
11 of 13 checks passed
anik120 added a commit to anik120/operator-framework-catalogd that referenced this pull request Sep 26, 2024
@anik120
UPSTREAM: <carry>: Add hostPath mount for /var/lib/kubelet
8e9ff74 
MCO makes the global pull secrets available in `/var/lib/kubelet`.
Catalogd will look for these secrets in `/etc/catalogd`
folder, ref [catalogd:416](operator-framework/catalogd#416).

This PR hostPath mounts the `/var/lib/kublet` directory from the host to the
`/etc/catalogd` directory in the container's filesystem.

RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing)
Signed-off-by: Anik Bhattacharjee <[email protected]>
openshift-merge-bot bot pushed a commit to openshift/operator-framework-catalogd that referenced this pull request Sep 26, 2024
@anik120 @openshift-merge-bot
UPSTREAM: <carry>: Add hostPath mount for /var/lib/kubelet
89e207c 
MCO makes the global pull secrets available in `/var/lib/kubelet`.
Catalogd will look for these secrets in `/etc/catalogd`
folder, ref [catalogd:416](operator-framework/catalogd#416).

This PR hostPath mounts the `/var/lib/kublet` directory from the host to the
`/etc/catalogd` directory in the container's filesystem.

RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing)
Signed-off-by: Anik Bhattacharjee <[email protected]>
tmshort pushed a commit to tmshort/operator-framework-catalogd that referenced this pull request Oct 7, 2024
@anik120 @tmshort
UPSTREAM: <carry>: Add hostPath mount for /var/lib/kubelet
0a28bfc 
MCO makes the global pull secrets available in `/var/lib/kubelet`.
Catalogd will look for these secrets in `/etc/catalogd`
folder, ref [catalogd:416](operator-framework/catalogd#416).

This PR hostPath mounts the `/var/lib/kublet` directory from the host to the
`/etc/catalogd` directory in the container's filesystem.

RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing)
Signed-off-by: Anik Bhattacharjee <[email protected]>
openshift-bot pushed a commit to openshift-bot/operator-framework-catalogd that referenced this pull request Oct 9, 2024
@anik120
UPSTREAM: <carry>: Add hostPath mount for /var/lib/kubelet
7d0a583 
MCO makes the global pull secrets available in `/var/lib/kubelet`.
Catalogd will look for these secrets in `/etc/catalogd`
folder, ref [catalogd:416](operator-framework/catalogd#416).

This PR hostPath mounts the `/var/lib/kublet` directory from the host to the
`/etc/catalogd` directory in the container's filesystem.

RFC: [OLMv1 Private registry support](https://docs.google.com/document/d/1BXD6kj5zXHcGiqvJOikU2xs8kV26TPnzEKp6n7TKD4M/edit?usp=sharing)
Signed-off-by: Anik Bhattacharjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

Assignees

@anik120 anik120

Labels
None yet
Projects
OLM v1
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anik120 @joelanford