Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠ Update the Progressing Status condition Terminal reason to Blocked #414

Merged

Conversation

anik120
Copy link
Collaborator

@anik120 anik120 commented Sep 24, 2024

Closes 412

@anik120 anik120 requested a review from a team as a code owner September 24, 2024 15:34
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.05%. Comparing base (ae6d3ef) to head (67f8d51).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   36.05%   36.05%           
=======================================
  Files          14       14           
  Lines         796      796           
=======================================
  Hits          287      287           
  Misses        463      463           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven
Copy link
Collaborator

Looks like upgrade-e2e is failing on waiting for a status condition. Kicking it again to see if it might be just a timing thing

@everettraven
Copy link
Collaborator

Upgrade-e2e looks like it is still failing. Could you look into it? If it is expected to fail, why?

Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to prevent this from merging before verifying upgrade-e2e failure

@perdasilva
Copy link
Contributor

Requesting changes to prevent this from merging before verifying upgrade-e2e failure

It's failing here as well: #413 i think there's something funky going on

@perdasilva
Copy link
Contributor

Attempting to fix it here: #415

@anik120 anik120 dismissed everettraven’s stale review September 25, 2024 10:24

Per's PR is fixing the cause of the upgrade-e2e test failure.

@anik120
Copy link
Collaborator Author

anik120 commented Sep 25, 2024

Realized can't auto-merge this since go-apidiff is failing (as expected) >.<

@everettraven everettraven added this pull request to the merge queue Sep 25, 2024
Merged via the queue into operator-framework:main with commit e57db1f Sep 25, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1 API Review] Update the Progressing status condition Terminal reason to Blocked
3 participants